From: Matheus Alcantara <matheusssilv97@gmail.com>
To: Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Matheus Alcantara <matheusssilv97@gmail.com>
Cc: Álvaro Herrera <alvherre@kurilemu.de>
Cc: Joel Jacobson <joel@compiler.org>
Cc: Rishu Bagga <rishu.postgres@gmail.com>
Cc: Yura Sokolov <y.sokolov@postgrespro.ru>
Cc: Daniil Davydov <3danissimo@gmail.com>
Cc: Alexandra Wang <alexandra.wang.oss@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: LISTEN/NOTIFY bug: VACUUM sets frozenxid past a xid in async queue
Date: Fri, 24 Oct 2025 21:33:33 -0300
Message-ID: <DDQZBKAC1KZ4.3LT22J6Q74JV0@gmail.com> (raw)
In-Reply-To: <CAE7r3MJK9irHqpZ9vfRmz-BZSjwq4oyjR4ppmaMp2g2GePf55g@mail.gmail.com>
References: <DDOYDH17RU0G.1R4MKAZKP87QV@gmail.com>
<202510221548.tgggefdrlpo3@alvherre.pgsql>
<DDP0YT14VYUG.34K8AP6EHU2TR@gmail.com>
<CAD21AoBKTF9SKSANX3xeXV9NjyDGYJeYEFN4duf--Tk=_exTYQ@mail.gmail.com>
<CAE7r3MJK9irHqpZ9vfRmz-BZSjwq4oyjR4ppmaMp2g2GePf55g@mail.gmail.com>
On Fri Oct 24, 2025 at 4:36 AM -03, Arseniy Mukhin wrote:
>> I would expect to add 002_aborted_tx_notifies.pl in a separate patch
>> since it's not related to this bug fix.
>>
>> ---
>> +# Test checks that listeners do not receive notifications from aborted
>> +# transaction even if notifications have been added to the listen/notify
>> +# queue. To reproduce it we use the fact that serializable conflicts
>> +# are checked after tx adds notifications to the queue.
>>
>> I wonder if we could implement this test using the isolation test
>> instead of the tap test. Is there any reason why you used a tap test
>> for that?
>>
>
> I agree it's less relevant to the patch now than it was with the new
> 'committed' field approach. And there is no particular reason why it
> was implemented as a TAP test actually.. So +1 to move it to separate
> patch (does it mean to separate thread as well or just separate patch
> file?) and rewrite as an isolation test (IIUC it's better to use
> isolation test infrastructure if it's possible). I can try to do it if
> nobody else does it earlier.
>
On the v11 version that I've sent on [1] I've move this test into a
separate patch, please feel free to implement it as an isolation test if
you want it.
[1] https://www.postgresql.org/message-id/DDQZB2AD34V4.3RH2USCA72AS8%40gmail.com
--
Matheus Alcantara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: matheusssilv97@gmail.com, arseniy.mukhin.dev@gmail.com, sawada.mshk@gmail.com, alvherre@kurilemu.de, joel@compiler.org, rishu.postgres@gmail.com, y.sokolov@postgrespro.ru, 3danissimo@gmail.com, alexandra.wang.oss@gmail.com, tgl@sss.pgh.pa.us
Subject: Re: LISTEN/NOTIFY bug: VACUUM sets frozenxid past a xid in async queue
In-Reply-To: <DDQZBKAC1KZ4.3LT22J6Q74JV0@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox