public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tristan Partin <[email protected]>
To: Srirama Kucherlapati <[email protected]>
To: Peter Eisentraut <[email protected]>
To: [email protected] <[email protected]>
To: Heikki Linnakangas <[email protected]>
Cc: AIX PG user <[email protected]>
Subject: Re: AIX support
Date: Sun, 21 Dec 2025 08:19:04 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <SJ4PPFB817783267BD66F22BFC328D93F81DBA8A@SJ4PPFB81778326.namprd15.prod.outlook.com>
References: <CY5PR11MB63928CC05906F27FB10D74D0FD322@CY5PR11MB6392.namprd11.prod.outlook.com>
	<[email protected]>
	<176279401378.2081919.12877701948713975661.pgcf@coridan.postgresql.org>
	<SJ4PPFB817783263EA0FD91EBC346308C51DBA3A@SJ4PPFB81778326.namprd15.prod.outlook.com>
	<[email protected]>
	<SJ4PPFB817783267BD66F22BFC328D93F81DBA8A@SJ4PPFB81778326.namprd15.prod.outlook.com>

Thanks for your continued push for AIX support! Here are a few comments:

> # The static libpq is skipped in AIX. This is not required.

For comments like this, I would generally like to see some links or 
inline documentation to why this is the case. Maybe Peter or Heikki 
disagree.

There are a few places in the Meson code like the following:

	if AIX:
		don't define the static library target
	endif

Make sure that the innards of the if statements are indented. 
Alternatively, you could define something like:

	static_library_dependencies = []
	if host_machine.system() == 'AIX'
		# TODO: Document this
		AIX_poison_pill = disabler()
		static_library_dependencies += AIX_poison_pill
	endif

And then for all static library definitions, you would just make sure 
that they all depend on the poison pill. You could document the AIX 
shared/static library situation where the AIX_poison_pill variable is 
defined. I'd like to see if Peter thinks this is a good idea before 
implementing it.

I'm also a little confused by the second patch. Some of it seems to be 
the same, and some other parts seem to be new. Should we consolidate all 
Meson AIX support into one patch? Overall, I think the size of the patch 
is good, and seem pretty maintainable.

-- 
Tristan Partin
Databricks (https://databricks.com)

view thread (73+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: AIX support
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox