public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tristan Partin <[email protected]>
To: Amul Sul <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Cleanup: Replace sscanf with strtol/strtoul in snapmgr
Date: Tue, 05 May 2026 16:01:04 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAAJ_b974KcAQ=XMBfw-iy2tnbwNk9YnSA5XcQctf7N0GUSDRQA@mail.gmail.com>
References: <CAAJ_b97mG=6ybUYE8nQyDfKkhaxTCD8rE8s6L8efNmqHaUYNWQ@mail.gmail.com>
	<[email protected]>
	<CAAJ_b974KcAQ=XMBfw-iy2tnbwNk9YnSA5XcQctf7N0GUSDRQA@mail.gmail.com>

On Tue May 5, 2026 at 2:24 AM CDT, Amul Sul wrote:
> On Mon, May 4, 2026 at 9:19 PM Tristan Partin <[email protected]> wrote:
>>
>> On Mon Apr 20, 2026 at 12:07 AM CDT, Amul Sul wrote:
>> The patch generally looks good. One comment:
>>
>> > @@ -1359,17 +1365,36 @@ parseVxidFromText(const char *prefix, char **s, const char *filename,
>> >  {
>> >         char       *ptr = *s;
>> >         int                     prefixlen = strlen(prefix);
>> > +       long            lval;
>> > +       unsigned long ulval;
>>
>> Perhaps better variable names would be procNumber and
>> localTransactionId.
>>
>
> Thanks, Andreas and Tristan, for the review !
>
> I have renamed the variables as suggested but used the shorter forms
> procno and xid instead of procNumber and localTransactionId. I also
> applied similar changes to parseXidFromText (changing val to xid), but
> kept val in parseIntFromText since it seems to be more appropriate for
> a generic integer value.
>
> Updated patch attached.

New patch looks good to me. I can confirm that the only changes in the 
new version of the patch are the variable names.

-- 
Tristan Partin
PostgreSQL Contributors Team
AWS (https://aws.amazon.com)

view thread (5+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Cleanup: Replace sscanf with strtol/strtoul in snapmgr
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox