agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Alberto Piai <alberto.piai@gmail.com>
To: Laurenz Albe <laurenz.albe@cybertec.at>
To: Alberto Piai <alberto.piai@gmail.com>
To: pgsql-hackers@postgresql.org
Cc: Álvaro Herrera <alvherre@kurilemu.de>
Subject: Re: Adding a stored generated column without long-lived locks
Date: Fri, 28 Aug 2026 18:07:17 +0200
Message-ID: <DL0PFQ4CM3KO.38HQUI04TKPLT@gmail.com> (raw)
In-Reply-To: <31fec16020bdf25d4a62cbbb4b8ea00af007e0d9.camel@cybertec.at>
References: <DJOPT622HYJK.3JRH1VQCV5CDL@gmail.com>
<2eb68e74ea95fc2f691de7d8cd28448d00d1d216.camel@cybertec.at>
<DJUGET7QLNRK.7G2H4M2PPJM9@gmail.com>
<79b63e772179abb4f5ad749d9e067d48a5537599.camel@cybertec.at>
<DKHUPZ08JV6G.2938OV580K72C@gmail.com>
<6f5ea02f6e5205a96a9b3979190a4d7cb3c99414.camel@cybertec.at>
<DKXFEG915LK8.12HECZQW2OWQE@gmail.com>
<86a9336dc25d9a085916ad247a5791dc53d2ab13.camel@cybertec.at>
<DKY5OJ1NSSGO.3U2FKRKCHM533@gmail.com>
<57bd5c0e2b532c07a1e6cd867520e899b1007622.camel@cybertec.at>
<DL0C8TG99HCO.1XVPKG2IM0C1S@gmail.com>
<31fec16020bdf25d4a62cbbb4b8ea00af007e0d9.camel@cybertec.at>
On Fri Aug 28, 2026 at 3:36 PM CEST, Laurenz Albe wrote:
> On Fri, 2026-08-28 at 07:50 +0200, Alberto Piai wrote:
>> Here's v9, rebased on top of current master.
>
> I can't find any fault with it; will mark it as "ready for committer".
Thanks again for all the effort you put into reviewing this, very much
appreciated!
Before this gets eventually picked up by a committer: I am having second
thoughts about my choice to allow = in addition to IS NOT DISTINCT FROM.
The patch can absolutely be reviewed with that in mind, I think.
Removing support for = would be an isolated change which wouldn't affect
the rest of the implementation.
As it stands, I'd probably prefer it committed without that, and expand
on the first commit at a later point.
Anyway I'll try to find time to think about a more convincing proof (or
a counterexample) over the next couple of days.
Best regards,
Alberto
--
Alberto Piai
Sensational AG
Zürich, Switzerland
view thread (36+ messages) latest in thread
Message-ID: <DL0PFQ4CM3KO.38HQUI04TKPLT@gmail.com>
Permalink: ../DL0PFQ4CM3KO.38HQUI04TKPLT@gmail.com/
Also on: postgresql.org/message-id/DL0PFQ4CM3KO.38HQUI04TKPLT@gmail.com
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alberto.piai@gmail.com, laurenz.albe@cybertec.at, alvherre@kurilemu.de
Subject: Re: Adding a stored generated column without long-lived locks
In-Reply-To: <DL0PFQ4CM3KO.38HQUI04TKPLT@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox