public inbox for [email protected]  

help / color / mirror / Atom feed

From: Mark Dilger <[email protected]>
To: Joshua Brindle <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: Jeff Davis <[email protected]>
Cc: Joe Conway <[email protected]>
Cc: Stephen Frost <[email protected]>
Subject: Re: New Object Access Type hooks
Date: Fri, 18 Mar 2022 08:15:47 -0700
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAGB+Vh5PFQskeJDGCSBYMZHKDP9Wo6hLJ_=SnzE=SQwoXaToiA@mail.gmail.com>
References: <[email protected]>
	<CAGB+Vh5PFQskeJDGCSBYMZHKDP9Wo6hLJ_=SnzE=SQwoXaToiA@mail.gmail.com>



> On Mar 18, 2022, at 7:16 AM, Joshua Brindle <[email protected]> wrote:
> 
> This is great, thank you for doing this. I didn't even realize the OAT
> hooks had no regression tests.
> 
> It looks good to me, I reviewed both and tested the module. I wonder
> if the slight abuse of subid is warranted with brand new hooks going
> in but not enough to object, I just hope this doesn't rise to the too
> large to merge this late level.

The majority of the patch is regression testing code, stuff which doesn't get installed.  It's even marked as NO_INSTALLCHECK, so it won't get installed even as part of "make installcheck".  That seems safe enough to me.

Not including tests of OAT seems worse, as it leaves us open to breaking the behavior without realizing we've done so.  A refactoring of the core code might cause hooks to be called in a different order, something which isn't necessarily wrong, but should not be done unknowingly.

—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: New Object Access Type hooks
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox