public inbox for [email protected]  

help / color / mirror / Atom feed

Fix Grammar in Buffer Lock Wait Message
2+ messages / 2 participants
[nested] [flat]

* Fix Grammar in Buffer Lock Wait Message
@ 2026-07-01 01:44  Guoqing Yang <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Guoqing Yang @ 2026-07-01 01:44 UTC (permalink / raw)
  To: [email protected]

Fix grammar in buffer lock wait message

Correct the wait message from "Waiting to acquire a exclusive lock on a 
buffer"
to "Waiting to acquire an exclusive lock on a buffer".

The word "exclusive" starts with a vowel sound, so the indefinite article
should be "an" instead of "a".

Regards,
Guoqing Yang


diff --git a/src/backend/utils/activity/wait_event_names.txt b/src/backend/utils/activity/wait_event_names.txt
index 560659f9568..bafdd7d2e96 100644
--- a/src/backend/utils/activity/wait_event_names.txt
+++ b/src/backend/utils/activity/wait_event_names.txt
@@ -294,7 +294,7 @@ Section: ClassName - WaitEventBuffer
 BUFFER_CLEANUP "Waiting to acquire an exclusive pin on a buffer. Buffer pin waits can be protracted if another process holds an open cursor that last read data from the buffer in question."
 BUFFER_SHARED  "Waiting to acquire a shared lock on a buffer."
 BUFFER_SHARE_EXCLUSIVE "Waiting to acquire a share exclusive lock on a buffer."
-BUFFER_EXCLUSIVE       "Waiting to acquire a exclusive lock on a buffer."
+BUFFER_EXCLUSIVE       "Waiting to acquire an exclusive lock on a buffer."

 ABI_compatibility:

Attachments:

  [text/plain] lockWaitMessage.diff (832B, ../../[email protected]/3-lockWaitMessage.diff)
  download | inline diff:
diff --git a/src/backend/utils/activity/wait_event_names.txt b/src/backend/utils/activity/wait_event_names.txt
index 560659f9568..bafdd7d2e96 100644
--- a/src/backend/utils/activity/wait_event_names.txt
+++ b/src/backend/utils/activity/wait_event_names.txt
@@ -294,7 +294,7 @@ Section: ClassName - WaitEventBuffer
 BUFFER_CLEANUP "Waiting to acquire an exclusive pin on a buffer. Buffer pin waits can be protracted if another process holds an open cursor that last read data from the buffer in question."
 BUFFER_SHARED  "Waiting to acquire a shared lock on a buffer."
 BUFFER_SHARE_EXCLUSIVE "Waiting to acquire a share exclusive lock on a buffer."
-BUFFER_EXCLUSIVE       "Waiting to acquire a exclusive lock on a buffer."
+BUFFER_EXCLUSIVE       "Waiting to acquire an exclusive lock on a buffer."

 ABI_compatibility:

^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: Fix Grammar in Buffer Lock Wait Message
@ 2026-07-01 02:02  Chao Li <[email protected]>
  parent: Guoqing Yang <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Chao Li @ 2026-07-01 02:02 UTC (permalink / raw)
  To: Guoqing Yang <[email protected]>; +Cc: [email protected]; Andres Freund <[email protected]>



> On Jul 1, 2026, at 09:44, Guoqing Yang <[email protected]> wrote:
> 
> Fix grammar in buffer lock wait message
> Correct the wait message from "Waiting to acquire a exclusive lock on a buffer"
> to "Waiting to acquire an exclusive lock on a buffer".
> The word "exclusive" starts with a vowel sound, so the indefinite article
> should be "an" instead of "a".
> Regards,
> Guoqing Yang
> 

Nice catch.

The typo is in wait_event_names.txt, so it actually affects the docs. See the attached doc screenshot.
```
BufferCleanup Waiting to acquire **an exclusive** pin on a buffer. Buffer pin waits can be
BufferExclusive Waiting to acquire **a exclusive** lock on a buffer. 
```

The row right above it uses “an exclusive”, while the next row uses “a exclusive”.

This seems to be an oversight from 6c5c393b7, so I think it should be back-patched to 19.

Best regards,*
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/






Attachments:

  [image/png] wait_event_name.png (86.6K, ../../[email protected]/2-wait_event_name.png)
  download | view image

^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2026-07-01 02:02 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-07-01 01:44 Fix Grammar in Buffer Lock Wait Message Guoqing Yang <[email protected]>
2026-07-01 02:02 ` Chao Li <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox