public inbox for [email protected]  

help / color / mirror / Atom feed

From: Daniel Gustafsson <[email protected]>
To: Alexander Pyhalov <[email protected]>
Cc: Ilya Gladyshev <[email protected]>
Cc: [email protected]
Subject: Re: Partial aggregates pushdown
Date: Mon, 15 Nov 2021 11:16:24 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

> On 3 Nov 2021, at 15:50, Alexander Pyhalov <[email protected]> wrote:
> 
> Daniel Gustafsson писал 2021-11-03 16:45:
>>> On 2 Nov 2021, at 10:12, Alexander Pyhalov <[email protected]> wrote:
>>> Updated and rebased patch.
>> +	state = (Int128AggState *) palloc0(sizeof(Int128AggState));
>> +	state->calcSumX2 = false;
>> +
>> +	if (!PG_ARGISNULL(0))
>> +	{
>> +#ifdef HAVE_INT128
>> +		do_int128_accum(state, (int128) PG_GETARG_INT64(0));
>> +#else
>> +		do_numeric_accum(state, int64_to_numeric(PG_GETARG_INT64(0)));
>> +#endif
>> This fails on non-INT128 platforms as state cannot be cast to Int128AggState
>> outside of HAVE_INT128; it's not defined there.  This needs to be a
>> PolyNumAggState no?
> 
> Hi.
> Thank you for noticing this. It's indeed fails with pgac_cv__128bit_int=no.
> Updated patch.

The updated patch also fails to apply now, but on the catversion.h bump.  To
avoid having to rebase for that I recommend to skip that part in the patch and
just mention the need in the thread, any committer picking this up for commit
will know to bump the catversion so there is no use in risking unneccesary
conflicts.

--
Daniel Gustafsson		https://vmware.com/

view thread (42+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Partial aggregates pushdown
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox