public inbox for [email protected]  

help / color / mirror / Atom feed

From: Daniel Gustafsson <[email protected]>
To: Jelte Fennema-Nio <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Ashutosh Bapat <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Add "format" target to make and ninja to run pgindent and pgperltidy
Date: Fri, 13 Mar 2026 23:26:13 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAGECzQTsrBm1H5BqwvgeGYYMnYXT6Xnh3qGG3ggxA8_Xw=dHWw@mail.gmail.com>
References: <[email protected]>
	<CAExHW5tuJTmuikfkabWq+mvomucY3iQ_vV-10KAsZWM7Yg6tvg@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAGECzQTsrBm1H5BqwvgeGYYMnYXT6Xnh3qGG3ggxA8_Xw=dHWw@mail.gmail.com>

> On 13 Mar 2026, at 16:11, Jelte Fennema-Nio <[email protected]> wrote:
> 
> On Fri, 13 Mar 2026 at 11:03, Daniel Gustafsson <[email protected]> wrote:
>> The primary reason thus far has been that pgperltidy requires a specific
>> version of perltidy, no other version is accepted.  Imposing the burden of
>> installing that on a greater subset of people than a subset of committers
>> didn't seem palatable.
> 
> I think that makes sense if the burden is big, but with patch 0008 it
> becomes as simple as running a single command:
> src/tools/pgindent/get_perltidy

In todays world of supply-chain attacks, don't think it's all that palatable to
take responsibility for installing code in peoples environments.  Regardless, I
don't think the patch should remove the installation instructions.

--
Daniel Gustafsson

view thread (15+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Add "format" target to make and ninja to run pgindent and pgperltidy
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox