From: Bossart, Nathan <bossartn@amazon.com>
To: David Steele <david@pgmasters.net>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Dipesh Pandit <dipesh.pandit@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Andres Freund <andres@anarazel.de>
Cc: Hannu Krosing <hannuk@google.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: .ready and .done files considered harmful
Date: Tue, 5 Oct 2021 19:19:18 +0000
Message-ID: <EDB7F8FD-6252-4432-9882-4E440498EAF9@amazon.com> (raw)
In-Reply-To: <92ab14a5-5fde-b9f4-cd5c-9212d7753725@pgmasters.net>
References: <BA908168-9407-4706-BE22-FCE8A1F33562@amazon.com>
<CAN1g5_GCTCtDpVqXdvE0wn9_ZJqRdgMCApUp_pACfwvFzQ6k0Q@mail.gmail.com>
<1C74E389-64A7-45AB-826F-8379768A6853@amazon.com>
<20210915.104757.462650766526515461.horikyota.ntt@gmail.com>
<CAN1g5_GAoO43bgUVjw39D8HTG_1se4_6oFk5B0DZpqGOEQytvA@mail.gmail.com>
<C472F58F-4E9B-49C2-82FF-2E373ADEFE34@amazon.com>
<CA+TgmoboazMqV9agYF-2F-_crbw9ogQ-e66OgMPP_bqPb7+a4g@mail.gmail.com>
<92ab14a5-5fde-b9f4-cd5c-9212d7753725@pgmasters.net>
On 9/27/21, 11:06 AM, "Bossart, Nathan" <bossartn@amazon.com> wrote:
> On 9/24/21, 9:29 AM, "Robert Haas" <robertmhaas@gmail.com> wrote:
>> So what I am inclined to do is commit
>> v1-0001-Improve-performance-of-pgarch_readyXlog-with-many.patch.
>> However, v6-0001-Do-fewer-directory-scans-of-archive_status.patch has
>> perhaps evolved a bit more than the other one, so I thought I should
>> first ask whether any of those changes have influenced your thinking
>> about the batching approach and whether you want to make any updates
>> to that patch first. I don't really see that this is needed, but I
>> might be missing something.
>
> Besides sprucing up the comments a bit, I don't think there is
> anything that needs to be changed. The only other thing I considered
> was getting rid of the arch_files array. Instead, I would swap the
> comparator function the heap uses with a reverse one, rebuild the
> heap, and then have pgarch_readyXlog() return files via
> binaryheap_remove_first(). However, this seemed like a bit more
> complexity than necessary.
>
> Attached is a new version of the patch with some expanded comments.
I just wanted to gently bump this thread in case there is any
additional feedback. I should have some time to work on it this week.
Also, it's looking more and more like this patch will nicely assist
the batching/loadable backup module stuff [0].
Nathan
[0] https://postgr.es/m/E9035E94-EC76-436E-B6C9-1C03FBD8EF54%40amazon.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bossartn@amazon.com, david@pgmasters.net, robertmhaas@gmail.com, dipesh.pandit@gmail.com, horikyota.ntt@gmail.com, jeevan.ladhe@enterprisedb.com, sfrost@snowman.net, andres@anarazel.de, hannuk@google.com
Subject: Re: .ready and .done files considered harmful
In-Reply-To: <EDB7F8FD-6252-4432-9882-4E440498EAF9@amazon.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox