From: Bossart, Nathan <bossartn@amazon.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Magnus Hagander <magnus@hagander.net>
Subject: Re: archive modules
Date: Tue, 2 Nov 2021 16:10:07 +0000
Message-ID: <EEE89F96-BF41-4DE5-A0EA-8C8BD23BDEE5@amazon.com> (raw)
In-Reply-To: <CA+TgmoZfft6oCGYP3agn_Y_v3KPBauBZG60tfTm=_kke+xfvaw@mail.gmail.com>
References: <668D2428-F73B-475E-87AE-F89D67942270@amazon.com>
<e437bf15-9917-7b78-f326-90b9c57ba8ae@oss.nttdata.com>
<YYDLd7vsmrYHC+9C@paquier.xyz>
<CA+TgmoYx1hhvmm4BLSJ15XM3ALrM6wyQ4XTesgtdgofSkHXqhA@mail.gmail.com>
<9970BE22-2BC3-49C9-AD68-51983118B701@amazon.com>
<CA+TgmoZfft6oCGYP3agn_Y_v3KPBauBZG60tfTm=_kke+xfvaw@mail.gmail.com>
On 11/2/21, 8:57 AM, "Robert Haas" <robertmhaas@gmail.com> wrote:
> On Tue, Nov 2, 2021 at 11:26 AM Bossart, Nathan <bossartn@amazon.com> wrote:
>> Well, the current patch does require a reload since the modules are
>> preloaded, but maybe there is some way to avoid that.
>
> I think we could set things up so that if the value changes, you call
> a shutdown hook for the old library, load the new one, and call any
> startup hook for that one.
Yes, that seems doable. My point is that I've intentionally chosen to
preload the libraries at the moment so that it's possible to define
PGC_POSTMASTER GUCs and to use RegisterBackgroundWorker(). If we
think that switching archive modules without restarting is more
important, I believe we will need to take on a few restrictions.
Nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bossartn@amazon.com, robertmhaas@gmail.com, michael@paquier.xyz, masao.fujii@oss.nttdata.com, sfrost@snowman.net, magnus@hagander.net
Subject: Re: archive modules
In-Reply-To: <EEE89F96-BF41-4DE5-A0EA-8C8BD23BDEE5@amazon.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox