public inbox for [email protected]
help / color / mirror / Atom feed[PATCH 08/10] Default to zstd..
4+ messages / 3 participants
[nested] [flat]
* [PATCH 08/10] Default to zstd..
@ 2021-03-12 21:35 Justin Pryzby <[email protected]>
0 siblings, 0 replies; 4+ messages in thread
From: Justin Pryzby @ 2021-03-12 21:35 UTC (permalink / raw)
for CI, not for merge
---
configure | 6 ++++--
configure.ac | 2 +-
src/backend/access/transam/xlog.c | 2 +-
src/backend/utils/misc/guc.c | 2 +-
4 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/configure b/configure
index 81e23418b2..253f028fc4 100755
--- a/configure
+++ b/configure
@@ -1582,7 +1582,7 @@ Optional Packages:
use system time zone data in DIR
--without-zlib do not use Zlib
--without-lz4 build without LZ4 support
- --with-zstd build with Zstd compression library
+ --without-zstd build without Zstd compression library
--with-gnu-ld assume the C compiler uses GNU ld [default=no]
--with-ssl=LIB use LIB for SSL/TLS support (openssl)
--with-openssl obsolete spelling of --with-ssl=openssl
@@ -8740,7 +8740,9 @@ $as_echo "#define USE_ZSTD 1" >>confdefs.h
esac
else
- with_zstd=no
+ with_zstd=yes
+
+$as_echo "#define USE_ZSTD 1" >>confdefs.h
fi
diff --git a/configure.ac b/configure.ac
index d6f6349067..8d72710fa7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1005,7 +1005,7 @@ fi
# ZSTD
#
AC_MSG_CHECKING([whether to build with zstd support])
-PGAC_ARG_BOOL(with, zstd, no, [build with Zstd compression library],
+PGAC_ARG_BOOL(with, zstd, yes, [build without Zstd compression library],
[AC_DEFINE([USE_ZSTD], 1, [Define to 1 to build with zstd support. (--with-zstd)])])
AC_MSG_RESULT([$with_zstd])
AC_SUBST(with_zstd)
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index 307eee6626..92023de9f5 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -99,7 +99,7 @@ bool EnableHotStandby = false;
bool fullPageWrites = true;
bool wal_log_hints = false;
bool wal_compression = false;
-int wal_compression_method = WAL_COMPRESSION_LZ4;
+int wal_compression_method = WAL_COMPRESSION_ZSTD;
char *wal_consistency_checking_string = NULL;
bool *wal_consistency_checking = NULL;
bool wal_init_zero = true;
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index 52f9cd0242..8031e027aa 100644
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -4728,7 +4728,7 @@ static struct config_enum ConfigureNamesEnum[] =
NULL
},
&wal_compression_method,
- WAL_COMPRESSION_LZ4, wal_compression_options,
+ WAL_COMPRESSION_ZSTD, wal_compression_options,
NULL, NULL, NULL
},
--
2.17.0
--XsQoSWH+UP9D9v3l
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="0009-Add-zstd-compression-levels.patch"
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Unstable tests for recovery conflict handling
@ 2022-04-27 17:11 Mark Dilger <[email protected]>
2022-04-27 17:50 ` Re: Unstable tests for recovery conflict handling Mark Dilger <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Mark Dilger @ 2022-04-27 17:11 UTC (permalink / raw)
To: Tom Lane <[email protected]>; +Cc: Andres Freund <[email protected]>; Melanie Plageman <[email protected]>; [email protected]
> On Apr 27, 2022, at 9:45 AM, Tom Lane <[email protected]> wrote:
>
> [ starting a new thread cuz the shared-stats one is way too long ]
>
> Andres Freund <[email protected]> writes:
>> Add minimal tests for recovery conflict handling.
>
> It's been kind of hidden by other buildfarm noise, but
> 031_recovery_conflict.pl is not as stable as it should be [1][2][3][4].
>
> Three of those failures look like
Interesting,
I have been getting failures on REL_14_STABLE:
t/012_subtransactions.pl ............. 11/12
# Failed test 'Rollback of PGPROC_MAX_CACHED_SUBXIDS+ prepared transaction on promoted standby'
# at t/012_subtransactions.pl line 211.
# got: '3'
# expected: '0'
t/012_subtransactions.pl ............. 12/12 # Looks like you failed 1 test of 12.
t/012_subtransactions.pl ............. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/12 subtests
And the logs, tmp_check/log/regress_log_012_subtransactions, showing:
### Enabling streaming replication for node "primary"
### Starting node "primary"
# Running: pg_ctl -D /Users/mark.dilger/recovery_test/postgresql/src/test/recovery/tmp_check/t_012_subtransactions_primary_data/pgdata -l /Users/mark.dilger/recovery_test/postgresql/src/test/recovery/tmp_check/log/012_subtransactions_primary.log -o --cluster-name=primary start
waiting for server to start.... done
server started
# Postmaster PID for node "primary" is 46270
psql:<stdin>:1: ERROR: prepared transaction with identifier "xact_012_1" does not exist
not ok 11 - Rollback of PGPROC_MAX_CACHED_SUBXIDS+ prepared transaction on promoted standby
# Failed test 'Rollback of PGPROC_MAX_CACHED_SUBXIDS+ prepared transaction on promoted standby'
# at t/012_subtransactions.pl line 211.
# got: '3'
# expected: '0'
This is quite consistent for me, but only when I configure with --enable-coverage and --enable-dtrace. (I haven't yet tried one of those without the other.)
I wasn't going to report this yet, having not yet completely narrowed this down, but I wonder if anybody else is seeing this?
I'll try again on master....
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Unstable tests for recovery conflict handling
2022-04-27 17:11 Re: Unstable tests for recovery conflict handling Mark Dilger <[email protected]>
@ 2022-04-27 17:50 ` Mark Dilger <[email protected]>
2022-05-11 05:28 ` Re: Unstable tests for recovery conflict handling Thomas Munro <[email protected]>
0 siblings, 1 reply; 4+ messages in thread
From: Mark Dilger @ 2022-04-27 17:50 UTC (permalink / raw)
To: Tom Lane <[email protected]>; +Cc: Andres Freund <[email protected]>; Melanie Plageman <[email protected]>; [email protected]
> On Apr 27, 2022, at 10:11 AM, Mark Dilger <[email protected]> wrote:
>
> I'll try again on master....
Still with coverage and dtrace enabled, I get the same thing, except that master formats the logs a bit differently:
# Postmaster PID for node "primary" is 19797
psql:<stdin>:1: ERROR: prepared transaction with identifier "xact_012_1" does not exist
[10:26:16.314](1.215s) not ok 11 - Rollback of PGPROC_MAX_CACHED_SUBXIDS+ prepared transaction on promoted standby
[10:26:16.314](0.000s)
[10:26:16.314](0.000s) # Failed test 'Rollback of PGPROC_MAX_CACHED_SUBXIDS+ prepared transaction on promoted standby'
[10:26:16.314](0.000s) # at t/012_subtransactions.pl line 208.
[10:26:16.314](0.000s) # got: '3'
# expected: '0'
With coverage but not dtrace enabled, I still get the error, though the log leading up to the error now has a bunch of coverage noise lines like:
profiling: /Users/mark.dilger/recovery_test/postgresql/src/backend/utils/sort/tuplesort.gcda: cannot merge previous GCDA file: corrupt arc tag
The error itself looks the same except the timing numbers differ a little.
With neither enabled, all tests pass.
I'm inclined to think that either the recovery code or the test have a race condition, and that enabling coverage causes the race to come out differently. I'll keep poking....
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Unstable tests for recovery conflict handling
2022-04-27 17:11 Re: Unstable tests for recovery conflict handling Mark Dilger <[email protected]>
2022-04-27 17:50 ` Re: Unstable tests for recovery conflict handling Mark Dilger <[email protected]>
@ 2022-05-11 05:28 ` Thomas Munro <[email protected]>
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Munro @ 2022-05-11 05:28 UTC (permalink / raw)
To: Mark Dilger <[email protected]>; +Cc: Tom Lane <[email protected]>; Andres Freund <[email protected]>; Melanie Plageman <[email protected]>; PostgreSQL Hackers <[email protected]>
On Thu, Apr 28, 2022 at 5:50 AM Mark Dilger
<[email protected]> wrote:
> psql:<stdin>:1: ERROR: prepared transaction with identifier "xact_012_1" does not exist
> [10:26:16.314](1.215s) not ok 11 - Rollback of PGPROC_MAX_CACHED_SUBXIDS+ prepared transaction on promoted standby
> [10:26:16.314](0.000s)
> [10:26:16.314](0.000s) # Failed test 'Rollback of PGPROC_MAX_CACHED_SUBXIDS+ prepared transaction on promoted standby'
> [10:26:16.314](0.000s) # at t/012_subtransactions.pl line 208.
> [10:26:16.314](0.000s) # got: '3'
> # expected: '0'
FWIW I see that on my FBSD/clang system when I build with
-fsanitize=undefined -fno-sanitize-recover=all. It's something to do
with our stack depth detection and tricks being used by -fsanitize,
because there's a stack depth exceeded message in the log.
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2022-05-11 05:28 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-03-12 21:35 [PATCH 08/10] Default to zstd.. Justin Pryzby <[email protected]>
2022-04-27 17:11 Re: Unstable tests for recovery conflict handling Mark Dilger <[email protected]>
2022-04-27 17:50 ` Re: Unstable tests for recovery conflict handling Mark Dilger <[email protected]>
2022-05-11 05:28 ` Re: Unstable tests for recovery conflict handling Thomas Munro <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox