public inbox for [email protected]
help / color / mirror / Atom feedFrom: Zhijie Hou (Fujitsu) <[email protected]>
To: shveta malik <[email protected]>
To: Bertrand Drouvot <[email protected]>
Cc: Amit Kapila <[email protected]>
Cc: Masahiko Sawada <[email protected]>
Cc: Dilip Kumar <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: Nisha Moond <[email protected]>
Cc: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: Bharath Rupireddy <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: Ashutosh Sharma <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: Ajin Cherian <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Subject: RE: Synchronizing slots from primary to standby
Date: Mon, 22 Jan 2024 08:49:11 +0000
Message-ID: <OS0PR01MB57160C7184E17C6765AAE38294752@OS0PR01MB5716.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAJpy0uDK=DfChioOaHon3LGZ7UusVLzzv_nYpoZVrzHX08Jdgw@mail.gmail.com>
References: <CAA4eK1+q8R=yEpTMiOZ_Xksdd_Jg3SXvBMxRutHQtkCbdeK_yQ@mail.gmail.com>
<CAJpy0uAU+nzufQwSzyB2YmhPHHn71_=1zkauP4Ra32a_eqbcig@mail.gmail.com>
<CAA4eK1KtwFg6Mr1MRnHUUfPotzc2=5UCTq_D2t8x0PM1Lyhk8g@mail.gmail.com>
<CAD21AoA03f0QKYjiSymGcnROvh1X-3YSqyB-19mkRXt5dfaxFw@mail.gmail.com>
<CAJpy0uCneiKeNuz3B91Wf2LRxAenD3fpaxYfdL09y9qHmvVp+w@mail.gmail.com>
<CAJpy0uCJ7MKgZnKLAACd-AXN0VbWM5gVJ+GRJ1Za_A2UmF3R0A@mail.gmail.com>
<[email protected]>
<CAJpy0uBrBc+YNxCGwCjXR+9UJZqM3QvjNq86cBy4K7kp_EXxhQ@mail.gmail.com>
<CAA4eK1JFhbBf-LywUU0YJUTcKTFjZvbXi-42DwCd-xojWKhRXA@mail.gmail.com>
<CAJpy0uD+ODUF+D0GX38F_UQYTqA8wvTEUPOCBa-9guLLRMhFWQ@mail.gmail.com>
<[email protected]>
<CAJpy0uBVDTbiLweRNMt53qMSOnPObocwDVhAdvsNCsNRQ3aNhA@mail.gmail.com>
<CAJpy0uDK=DfChioOaHon3LGZ7UusVLzzv_nYpoZVrzHX08Jdgw@mail.gmail.com>
On Monday, January 22, 2024 11:36 AM shveta malik <[email protected]> wrote:
Hi,
> On Fri, Jan 19, 2024 at 4:18 PM shveta malik <[email protected]> wrote:
> >
> > PFA v64.
>
> V64 fails to apply to HEAD due to a recent commit. Rebased it. PFA v64_2. It has
> no new changes.
I noticed few things while analyzing the patch.
1.
sleep_ms = Min(sleep_ms * 2, MAX_WORKER_NAPTIME_MS);
The initial value for sleep_ms is 0(default value for static variable) which
will not be advanced in this expression. We should initialize sleep_ms to a positive
number.
2.
/ Wait a bit, we don't expect to have to wait long /
rc = WaitLatch(MyLatch,
WL_LATCH_SET | WL_TIMEOUT | WL_EXIT_ON_PM_DEATH,
10L, WAIT_EVENT_BGWORKER_SHUTDOWN);
The slotsync worker is not a bgworker anymore after 0003 patch, so a new event
is needed I think.
3.
slot->effective_catalog_xmin = xmin_horizon;
The assignment is also needed in local_slot_update() to make
ReplicationSlotsComputeRequiredXmin work.
Best Regards,
Hou zj
view thread (119+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: RE: Synchronizing slots from primary to standby
In-Reply-To: <OS0PR01MB57160C7184E17C6765AAE38294752@OS0PR01MB5716.jpnprd01.prod.outlook.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox