public inbox for [email protected]
help / color / mirror / Atom feedFrom: Srirama Kucherlapati <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: AIX PG user <[email protected]>
Cc: Heikki Linnakangas <[email protected]>
Cc: Tristan Partin <[email protected]>
Cc: [email protected] <[email protected]>
Subject: RE: AIX support
Date: Thu, 22 Jan 2026 16:08:36 +0000
Message-ID: <SJ4PPFB81778326E995FAD5945ECF752FA1DB96A@SJ4PPFB81778326.namprd15.prod.outlook.com> (raw)
In-Reply-To: <[email protected]>
References: <CY5PR11MB63928CC05906F27FB10D74D0FD322@CY5PR11MB6392.namprd11.prod.outlook.com>
<[email protected]>
<176279401378.2081919.12877701948713975661.pgcf@coridan.postgresql.org>
<SJ4PPFB817783263EA0FD91EBC346308C51DBA3A@SJ4PPFB81778326.namprd15.prod.outlook.com>
<[email protected]>
<SJ4PPFB817783267BD66F22BFC328D93F81DBA8A@SJ4PPFB81778326.namprd15.prod.outlook.com>
<[email protected]>
<SJ4PPFB8177832684055FA99E25A710A09BDBB2A@SJ4PPFB81778326.namprd15.prod.outlook.com>
<SJ4PPFB817783265975DE0984EE26A94891DBBBA@SJ4PPFB81778326.namprd15.prod.outlook.com>
<SJ4PPFB817783261597674B9814FE523944DB8EA@SJ4PPFB81778326.namprd15.prod.outlook.com>
<[email protected]>
<SJ4PPFB8177832645802E05CC9DD299E792DB8CA@SJ4PPFB81778326.namprd15.prod.outlook.com>
<[email protected]>
Hi Peter,
Thanks for looking into this and providing your feedback.
> I took this idea of disabling static libraries in meson and made it a
> separate patch; see [0]. It looks like this patch is getting close to
> consensus, so we could commit it soon. Then you could rebase your patch
> over it, which would make it quite a bit simpler.
That’s a great idea and will definitely help simplify the overall changes.
Once that patch is committed, I’ll rebase my changes accordingly to align with the new approach.
> I think in general, the meson changes are ok. But I needed some
> changes, for example, your patch contains
Thanks for reviewing the changes.
> but the method .disabled() doesn't exist, it should be .found(). So I’m
> wondering how this patch was tested.
You’re correct — the method .disabled() doesn’t exist; it should be .found(). We initially tried to follow the same approach used for other dependencies (like docs, docs_pdf, gssapi), and didn’t encounter any errors during testing.
In Meson, the option() class implements disabled(), but the disabler() object does not. When we ran a sample test, we observed that Meson’s behaviour on AIX/Linux seems to ignore any unknown methods. As a result, the .disabled() conditional check was silently skipped, which explains why it didn’t fail during our tests.
> Another patch of interest to you could be [1], which moves the
> MAXIMUM_ALIGNOF computation into c.h. This should also simplify your
> patch. But that patch has not received any discussion so far.
This is a better approach. This would simplify the changes in both configure and meson.build.
> It's ok to split changes into multiple patches, and then recommend which parts you want
> reviewed first. But we need to see at least a rough outline of the
> complete plan before spending significant effort on reviewing the pieces.
Sure. We are working on the changes. I’ll submit the full patch accordingly.
Thanks again for your guidance and support!
Warm regards,
Sriram.
view thread (51+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: RE: AIX support
In-Reply-To: <SJ4PPFB81778326E995FAD5945ECF752FA1DB96A@SJ4PPFB81778326.namprd15.prod.outlook.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox