public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tatsuro Yamada <[email protected]>
To: Richard Guo <[email protected]>
Cc: Tatsuro Yamada <[email protected]>
Cc: David Rowley <[email protected]>
Cc: Ashutosh Bapat <[email protected]>
Cc: [email protected] <[email protected]>
Subject: RE: Add enable_groupagg GUC parameter to control GroupAggregate usage
Date: Wed, 8 Jul 2026 11:54:13 +0000
Message-ID: <TY4P301MB129960EF0C5955374C5E7A8A9EFF2@TY4P301MB1299.JPNP301.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CAMbWs4-0UTTMNftuJBpZuUp1zzGWjFgkHSnwaqZdKG2Lo1fJAA@mail.gmail.com>
References: <CAOKkKFvYHSEsFazkrf9bRH14p-H27XMaqbZfRYjS6EHBruvZMQ@mail.gmail.com>
<CAExHW5tPhCw5HpHG6F7uAXx3re_gRXqm_ryJFjFQ2+WrVY+hPQ@mail.gmail.com>
<CAOKkKFsLbbpVMCG2_bV8u7M2sXLTs0y_yfMpywKekGi+qKtWKw@mail.gmail.com>
<CAOKkKFvgjAwtUFKh3baZ7BcQ5u+wS_DO+2n7dh0un+19v_VOzQ@mail.gmail.com>
<CAApHDvqq21KL9-eCfUyAUqxEyz40dut8+ehQHJD3Rh75iEMycw@mail.gmail.com>
<CAOKkKFvBi5tNaPkP-VEUcAr=nek0nm9=sUnP+dmqCm-vmnL9DA@mail.gmail.com>
<CAMbWs4-rqGC78jHduXO_feXCFzK=gzrcSHRTkATTKChG3YGq0A@mail.gmail.com>
<TY4P301MB129931A356F6934C432BB0259EEC2@TY4P301MB1299.JPNP301.PROD.OUTLOOK.COM>
<CAMbWs48cWQ=QkwH21zhfGH2MsAFYJpskjak99N4VX2yB69k-Eg@mail.gmail.com>
<TY4P301MB12997F863B7B51A520E02ABC9EE82@TY4P301MB1299.JPNP301.PROD.OUTLOOK.COM>
<CAMbWs49RCumHErWYOLm4jDcvLSGqhSm1Asnwsv9Tdn2Yjn0r2A@mail.gmail.com>
<CAMbWs4-0UTTMNftuJBpZuUp1zzGWjFgkHSnwaqZdKG2Lo1fJAA@mail.gmail.com>
Hi Richard,
>> Attached is a rebased patch to make cfbot work again.
>
>I intend to push this patch soon. That way newly added test cases can
>start using enable_groupagg directly. Otherwise we'll have to keep
>rebasing it to convert any new tests that use enable_sort to force
>hashed grouping. Any thoughts?
I'm in favor of committing this.
Before you do, I'd like to clarify one point regarding the commit message.
Would it make sense to list both of us as authors?
The reason I ask is that you made substantial changes to the patch,
including handling additional plan nodes such as SetOp and adding regression
tests. Given those contributions, I wondered whether it would be more
appropriate for both of us to be listed as authors. (I've seen past commits that
included two Author: lines.)
I'm happy to leave that decision to you.
By the way, I re-ran the test query from the initial email in this thread.
The execution times were:
Default: 25,791.642 ms
SET enable_groupagg TO off;: 1,006.839 ms
This again confirmed an approximately 25x speedup.
Of course, the actual benefit depends on the specific query, but I believe
this parameter will allow users to improve query performance in more situations.
Regards,
Tatsuro Yamada
> -----Original Message-----
> From: Richard Guo <[email protected]>
> Sent: Tuesday, July 7, 2026 3:53 PM
> To: Tatsuro Yamada（山田達朗） <[email protected]>
> Cc: Tatsuro Yamada <[email protected]>; David Rowley
> <[email protected]>; Ashutosh Bapat
> <[email protected]>; [email protected]
> Subject: Re: Add enable_groupagg GUC parameter to control GroupAggregate
> usage
>
> On Tue, Jul 7, 2026 at 3:47 PM Richard Guo <[email protected]>
> wrote:
> > Attached is a rebased patch to make cfbot work again.
>
> I intend to push this patch soon. That way newly added test cases can
> start using enable_groupagg directly. Otherwise we'll have to keep
> rebasing it to convert any new tests that use enable_sort to force
> hashed grouping. Any thoughts?
>
> - Richard
view thread (18+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: RE: Add enable_groupagg GUC parameter to control GroupAggregate usage
In-Reply-To: <TY4P301MB129960EF0C5955374C5E7A8A9EFF2@TY4P301MB1299.JPNP301.PROD.OUTLOOK.COM>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox