public inbox for [email protected]  

help / color / mirror / Atom feed
From: Hayato Kuroda (Fujitsu) <[email protected]>
To: 'Nathan Bossart' <[email protected]>
Cc: [email protected] <[email protected]>
Subject: RE: wake up logical workers after ALTER SUBSCRIPTION
Date: Wed, 30 Nov 2022 04:48:03 +0000
Message-ID: <TYAPR01MB58665A1D75B3921974A886F7F5159@TYAPR01MB5866.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20221130041028.GA1604177@nathanxps13>
References: <20221122004119.GA132961@nathanxps13>
	<TYAPR01MB5866233C60501EA7CBFE4385F50D9@TYAPR01MB5866.jpnprd01.prod.outlook.com>
	<20221122043916.GA230228@nathanxps13>
	<TYAPR01MB58667E500F238E0A1D155FFCF50D9@TYAPR01MB5866.jpnprd01.prod.outlook.com>
	<OS0PR01MB5716D57A52B59E31122418FA940D9@OS0PR01MB5716.jpnprd01.prod.outlook.com>
	<20221123205027.GA368966@nathanxps13>
	<TYCPR01MB58703BC1BD6B1415CA4BAB7FF50F9@TYCPR01MB5870.jpnprd01.prod.outlook.com>
	<20221127234528.GB878043@nathanxps13>
	<20221130041028.GA1604177@nathanxps13>

Dear Nathan,

> I spent some more time on the prevent-unnecessary-wakeups patch for
> logical/worker.c that I've been alluding to in this thread, and I found a
> few more places where we depend on the worker periodically waking up.  This
> seems to be a common technique, so I'm beginning to wonder whether these
> changes are worthwhile.  I think there's a good chance it would become a
> game of whac-a-mole.

I think at least this feature is needed for waking up workers that are slept due to the min_apply_delay.
The author supposed this patch and pinned our thread[1].

[1]: https://www.postgresql.org/message-id/TYCPR01MB8373775ECC6972289AF8CB30ED0F9%40TYCPR01MB8373.jpnprd0...

Best Regards,
Hayato Kuroda
FUJITSU LIMITED






view thread (46+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: RE: wake up logical workers after ALTER SUBSCRIPTION
  In-Reply-To: <TYAPR01MB58665A1D75B3921974A886F7F5159@TYAPR01MB5866.jpnprd01.prod.outlook.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox