public inbox for [email protected]help / color / mirror / Atom feed
[PATCH v6 02/10] doc: pg_stat_progress_basebackup 2+ messages / 2 participants [nested] [flat]
* [PATCH v6 02/10] doc: pg_stat_progress_basebackup @ 2020-03-30 02:22 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 2+ messages in thread From: Justin Pryzby @ 2020-03-30 02:22 UTC (permalink / raw) commit e65497df8f85ab9b9084c928ff69f384ea729b24 Author: Fujii Masao <[email protected]> --- doc/src/sgml/monitoring.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml index 304c49f07b..ea8780327f 100644 --- a/doc/src/sgml/monitoring.sgml +++ b/doc/src/sgml/monitoring.sgml @@ -6069,8 +6069,8 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid, <entry><literal>waiting for checkpoint to finish</literal></entry> <entry> The WAL sender process is currently performing - <function>pg_start_backup</function> to set up for - taking a base backup, and waiting for backup start + <function>pg_start_backup</function> to prepare to + take a base backup, and waiting for the start-of-backup checkpoint to finish. </entry> </row> -- 2.17.0 --C+ts3FVlLX8+P6JN Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v6-0003-Fix-docs-time-of-the.patch" ^ permalink raw reply [nested|flat] 2+ messages in thread
* Concerns regarding code in pgstat_backend.c @ 2026-02-06 07:11 Ryo Matsumura (Fujitsu) <[email protected]> 0 siblings, 0 replies; 2+ messages in thread From: Ryo Matsumura (Fujitsu) @ 2026-02-06 07:11 UTC (permalink / raw) To: [email protected] <[email protected]>; +Cc: pgsql-hackers Hi, Michael and Hackers, I found the code that is likely to cause bugs in the future. It's not currently a bug. Should I have misunderstood, please feel free to disregard this email. pgstat_create_backend(ProcNumber procnum) uses MyProcNumber instead of the argument. I've had a quick look through the commit log and thread, but I don't seem to have found the reason. Wouldn't it be better to use 'procnum'? This change seems to have appeared in v2-0002-More-work-to-allow-backend-statistics-in-critical.patch on 2025-01-20 06:34:41 https://www.postgresql.org/message-id/flat/66efowskppsns35v5u2m7k4sdnl7yoz5bo64tdjwq7r5lhplrz%40y7dm... Best Regards Ryo Matsumura ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-02-06 07:11 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2020-03-30 02:22 [PATCH v6 02/10] doc: pg_stat_progress_basebackup Justin Pryzby <[email protected]> 2026-02-06 07:11 Concerns regarding code in pgstat_backend.c Ryo Matsumura (Fujitsu) <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox