public inbox for [email protected]  
help / color / mirror / Atom feed
From: Kohei Harikae (Fujitsu) <[email protected]>
To: 'Vladlen Popolitov' <[email protected]>
Cc: 'Andres Freund' <[email protected]>
Cc: '[email protected]' <[email protected]>
Subject: RE: Windows meson build
Date: Fri, 27 Dec 2024 01:31:33 +0000
Message-ID: <TYVPR01MB1133078C93F9FE432CA466573E40E2@TYVPR01MB11330.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <[email protected]>
References: <TYVPR01MB113306AB19264E89AD360A40EE4522@TYVPR01MB11330.jpnprd01.prod.outlook.com>
	<gjqvs4lcv5mpl7io2dzm2jantxenavljs5437kjlhjk4lmxzep@ahia6adaioc2>
	<TYVPR01MB11330FC4B949E05FE6A0F437CE4052@TYVPR01MB11330.jpnprd01.prod.outlook.com>
	<[email protected]>

Hi,

Thank you for your advice.
I added a sample setting PKG_CONFIG_PATH based on your advice.

How do you think about this?

Regards,
Kohei Harikae

-----Original Message-----
From: Vladlen Popolitov <[email protected]> 
Sent: Wednesday, December 25, 2024 7:28 PM
To: Harikae, Kohei/張替 浩平 <[email protected]>
Cc: 'Andres Freund' <[email protected]>; '[email protected]' <[email protected]>
Subject: Re: Windows meson build

Kohei Harikae (Fujitsu) писал(а) 2024-12-18 05:05:
Hi!
> Hi,
> 
> I apologize for this late reply.
> 
> As you advised, I was able to create the ".pc" file manually and set 
> the dependencies using pkgconf.
> Thank you.
> 
> However, I have read the PostgreSQL Documentation and did not realize 
> that pkgconf is required.
> 
> 17.4.3.2. PostgreSQL Features
> -Dgssapi
>   On many systems, the GSSAPI system (a part of the MIT Kerberos
> installation) is not installed in a location that is searched by 
> default (e.g., /usr/include, /usr/lib).
>   In those cases, PostgreSQL will query pkg-config to detect the 
> required compiler and linker options.
> -Dlibxml
>   To use a libxml2 installation that is in an unusual location, you 
> can set pkg-config-related environment variables (see its documentation).
> 
> Only a few options have a pkg-config description.
> It would be easier to understand pkg-config in the "17.4.3. meson 
> setup Options" section.
> Below is my proposal for the document description.
> How do you think about this?
> 
> 17.4.3. meson setup Options
> PostgreSQL will query pkg-config to detect the required compiler and 
> linker options.
> To use module installed in an unusual location for each feature (e.g. 
> -Dgssapi, -Dlibxml), set pkg-config-related environment variables (see 
> its documentation).

Meson has more straighforward solution. It uses environment variable PKG_CONFIG_PATH, that can store the list of directories with all .pc files. Meson uses this list and in this specific order to build project. 
As wrote in meson documentation (in the source of open source project):
# Instead of relying on pkg-config or pkgconf to provide -L flags in a # specific order, we reorder library paths ourselves, according to th # order specified in PKG_CONFIG_PATH. See:
# https://github.com/mesonbuild/meson/issues/4271
#
It would be more clear information in PostgreSQL documentation, that all directories with pc files are listed in one variable.

By the way, if you need to add , f.e. libxml library to postgreSQL build, you can
1) build and install it using , f.e. vcpkg:
  vcpkg install libxml2:windows-x64 --x-install-root=c:\pbuild\libxml2
2) add path to pc directory to PKG_CONFIG_PATH
  SET
PKG_CONFIG_PATH=c:\pbuild\libxml2\winsows-x64\lib\pkgconfig;%PKG_CONFIG_PATH%
3) make steps with build
  meson setup c:\builddir\... --prefix=c:\postgresdir\...

It is just one install and one manipulation with environment variable. 
No indeterminate behaviour with other variables used by specific packages and a libraries order.

> 
> Regards,
> Kohei Harikae
> 
> -----Original Message-----
> From: Andres Freund <[email protected]>
> Sent: Thursday, November 7, 2024 4:05 AM
> To: Harikae, Kohei/張替 浩平 <[email protected]>
> Cc: '[email protected]' 
> <[email protected]>
> Subject: Re: Windows meson build
> 
> Hi,
> 
> On 2024-11-05 06:32:51 +0000, Kohei Harikae (Fujitsu) wrote:
>> I do not use pkgconf in my Windows environment.
>> In my Windows environment, I could not build the following OSS with 
>> meson.
>> - 0001 icu
>> - 0002 libxml
>> - 0003 libxslt
>> - 0004 lz4
>> - 0005 tcl
>> - 0006 zlib
>> - 0007 zstd
>> 
>> [1]thread, I created a patch like the one in the attached file, and 
>> now I can build.
>> Would you like to be able to build OSS with Windows meson without 
>> using pkgconf?
> 
> You can use pkgconf or cmake for the dependencies.  I don't want to 
> add "raw"
> dependency handling for every dependency, they each build in too many 
> variants for that to be a sensible investment of time.
> 
> 
> Greetings,
> 
> Andres Freund

--
Best regards,

Vladlen Popolitov.


Attachments:

  [application/octet-stream] installation-meson.patch (2.8K, 2-installation-meson.patch)
  download | inline diff:
diff --git a/doc/src/sgml/installation.sgml b/doc/src/sgml/installation.sgml
index ebdb5b3bc2d..c583c256858 100644
--- a/doc/src/sgml/installation.sgml
+++ b/doc/src/sgml/installation.sgml
@@ -2463,12 +2463,7 @@ ninja install
       <listitem>
        <para>
         Build with support for GSSAPI authentication. MIT Kerberos is required
-        to be installed for GSSAPI.  On many systems, the GSSAPI system (a part
-        of the MIT Kerberos installation) is not installed in a location
-        that is searched by default (e.g., <filename>/usr/include</filename>,
-        <filename>/usr/lib</filename>).  In
-        those cases, PostgreSQL will query <command>pkg-config</command> to
-        detect the required compiler and linker options.  Defaults to auto.
+        to be installed for GSSAPI.  Defaults to auto.
         <filename>meson configure</filename> will check for the required
         header files and libraries to make sure that your GSSAPI installation
         is sufficient before proceeding.
@@ -2589,12 +2584,6 @@ ninja install
         Build with libxml2, enabling SQL/XML support.  Defaults to
         auto. Libxml2 version 2.6.23 or later is required for this feature.
        </para>
-
-       <para>
-        To use a libxml2 installation that is in an unusual location, you
-        can set <command>pkg-config</command>-related environment
-        variables (see its documentation).
-       </para>
       </listitem>
      </varlistentry>
 
@@ -3174,6 +3163,43 @@ ninja install
    &targets-meson;
   </sect2>
 
+  <sect2 id="use-unusual-location-libraries-meson">
+   <title>Steps to use libraries installed in an unusual location</title>
+
+   <para>
+    PostgreSQL will query pkg-config to detect the required compiler and linker options.
+    To use modules installed in an unusual location, set pkg-config-related
+    environment variables (see its documentation). For example, if you want to add
+    the library to the PostgreSQL build, add the directory where the .pc file resides
+    to PKG_CONFIG_PATH.
+
+    Sample procedures to include libraries for PostgreSQL build are as follows:
+   </para>
+   
+    <procedure>
+    <step id="sample-build-library">
+     <title>Building and Installation library</title>
+     <para>
+      Check the path where the .pc file (e.g.libxml-2.0.pc) is created.
+     </para>
+    </step>
+    <step id="sample-add-PKG_CONFIG_PATH">
+     <title>Add path to .pc directory to PKG_CONFIG_PATH</title>
+     <para>
+     </para>
+    </step>
+    <step id="sample-build-meson">
+     <title>Building and Installation PostgreSQL with Meson</title>
+     <para>
+<screen>
+<userinput>meson setup build</userinput>
+</screen>
+     </para>
+    </step>
+    </procedure>
+   
+  </sect2>
+
  </sect1>
 
  <sect1 id="install-post">


view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: RE: Windows meson build
  In-Reply-To: <TYVPR01MB1133078C93F9FE432CA466573E40E2@TYVPR01MB11330.jpnprd01.prod.outlook.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox