public inbox for [email protected]  

help / color / mirror / Atom feed

From: Vladlen Popolitov <[email protected]>
To: Kohei Harikae (Fujitsu) <[email protected]>
Cc: 'Andres Freund' <[email protected]>
Cc: '[email protected]' <[email protected]>
Subject: Re: Windows meson build
Date: Fri, 27 Dec 2024 12:08:12 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <TYVPR01MB113306AB19264E89AD360A40EE4522@TYVPR01MB11330.jpnprd01.prod.outlook.com>
	<gjqvs4lcv5mpl7io2dzm2jantxenavljs5437kjlhjk4lmxzep@ahia6adaioc2>
	<TYVPR01MB11330FC4B949E05FE6A0F437CE4052@TYVPR01MB11330.jpnprd01.prod.outlook.com>
	<[email protected]>
	<TYVPR01MB1133078C93F9FE432CA466573E40E2@TYVPR01MB11330.jpnprd01.prod.outlook.com>
	<[email protected]>

Vladlen Popolitov писал(а) 2024-12-27 09:57:
> Kohei Harikae (Fujitsu) писал(а) 2024-12-27 04:31:
>> Hi,
>> 
>> Thank you for your advice.
>> I added a sample setting PKG_CONFIG_PATH based on your advice.
>> 
>> How do you think about this?
>> 
>> Regards,
>> Kohei Harikae
>> 
> 
> Hi,
> From my point of view it looks good. Actual information is added,
> excessive information is removed.
> I think in the phrase:
> "add the directory where the .pc file resides to PKG_CONFIG_PATH."
> better to add wording, that PKG_CONFIG_PATH is the list of directories 
> separated
> by PATH separator ( ; in Windows, : in POSIX). Otherwise the reader has 
> to
> search additional information about this variable in meson 
> documentation.

Hi

I think, it is better to add the other options how to configure external
libraries, if they do not have .pc file:
add meson options defined by PostgreSQL for its configuration (gettext 
library example)
  
-Dextra_include_dirs=c:\postgres\gettext\x64-windows\include,c:\otherlibs\include
  -Dextra_lib_dirs=c:\postgres\gettext\x64-windows\lib,c:\otherlibs\lib

extra_include_dirs and extra_lib_dirs are options defined by PostgreSQL. 
This options are
comma separated lists of directories, if every value does not contain 
comma itself.



-- 
Best regards,

Vladlen Popolitov.

view thread (5+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Windows meson build
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox