From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Make finding openssl program a configure or meson option
Date: Wed, 19 Oct 2022 12:06:04 +0900
Message-ID: <Y09pnCNN7Z6LGGLa@paquier.xyz> (raw)
In-Reply-To: <6b6df244-584b-1a48-484a-1f95a1ded097@enterprisedb.com>
References: <dc638b75-a16a-007d-9e1c-d16ed6cf0ad2@enterprisedb.com>
<Y0YTiPFasB1o1Fmo@paquier.xyz>
<6b6df244-584b-1a48-484a-1f95a1ded097@enterprisedb.com>
On Tue, Oct 18, 2022 at 06:46:53PM +0200, Peter Eisentraut wrote:
> On 12.10.22 03:08, Michael Paquier wrote:
>> openssl-env allows the use of the environment variable of the same
>> name. This reminds me a bit of the recent interferences with GZIP,
>> for example.
>
> Okay, I see what you meant here now. openssl-env is the man page describing
> environment variables used by OpenSSL.
Yeah, sorry. That's what I was referring to.
> I don't see any conflicts with what is being proposed here.
Its meaning is the same in the context of the OpenSSL code. LibreSSL
has nothing of the kind.
> Added. New patch attached.
Looks fine as a whole, except for one nit.
src/test/ssl/t/001_ssltests.pl: warn 'couldn\'t run `openssl x509` to get client cert serialno';
Perhaps this warning should mentioned $ENV{OPENSSL} instead?
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../Y09pnCNN7Z6LGGLa@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, peter.eisentraut@enterprisedb.com
Subject: Re: Make finding openssl program a configure or meson option
In-Reply-To: <Y09pnCNN7Z6LGGLa@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox