pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Soumyadeep Chakraborty <soumyadeep2007@gmail.com>
Cc: Sanaba, Bilva <bilvas@amazon.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Adding Support for Copy callback functionality on COPY TO api
Date: Sat, 8 Oct 2022 14:11:38 +0900
Message-ID: <Y0EGighrcVgNnp30@paquier.xyz> (raw)
In-Reply-To: <20221007214824.GA814385@nathanxps13>
References: <253C21D1-FCEB-41D9-A2AF-E6517015B7D7@amazon.com>
	<CAE-ML+_ebFzUnsgj-4MLshLGFfT05Lo15KK6rpcUt8-ZZKL1XQ@mail.gmail.com>
	<20200930074151.GR1996@paquier.xyz>
	<20220802234919.GA841243@nathanxps13>
	<Yz/L+3aC6CJ/hZ65@paquier.xyz>
	<20221007214824.GA814385@nathanxps13>

On Fri, Oct 07, 2022 at 02:48:24PM -0700, Nathan Bossart wrote:
> Here is an attempt at adding such a test module.

Using an ereport(NOTICE) to show the data reported in the callback is
fine by me.  How about making the module a bit more modular, by
passing as argument a regclass and building a list of arguments with
it?  You may want to hold the ShareAccessLock on the relation until
the end of the transaction in this example.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (17+ messages)  latest in thread

Message-ID: <Y0EGighrcVgNnp30@paquier.xyz>
Permalink:  ../Y0EGighrcVgNnp30@paquier.xyz/
Also on:    postgresql.org/message-id/Y0EGighrcVgNnp30@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, nathandbossart@gmail.com, soumyadeep2007@gmail.com, bilvas@amazon.com
  Subject: Re: Adding Support for Copy callback functionality on COPY TO api
  In-Reply-To: <Y0EGighrcVgNnp30@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox