public inbox for [email protected]  
help / color / mirror / Atom feed
From: Michael Paquier <[email protected]>
To: Bharath Rupireddy <[email protected]>
Cc: David Christensen <[email protected]>
Cc: Justin Pryzby <[email protected]>
Cc: Ian Lawrence Barwick <[email protected]>
Cc: Matthias van de Meent <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL
Date: Tue, 27 Dec 2022 12:31:27 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CALj2ACU2Owy6KhQ2sqWUt6MSyPXor4ha6p2BWoqf5v2_i2UB=Q@mail.gmail.com>
References: <CALj2ACWmgbDeCDMaZah0GRwQBCJMD01U4S69V6TE4W2jYmnLuQ@mail.gmail.com>
	<CAOxo6XJMcLyLb1D4oOV2FHfJvt1Z6DuediGUKKEHAEMvpPe2ow@mail.gmail.com>
	<[email protected]>
	<CAOxo6X+NCVAB3H5_TMSasgimf127KURoi=S0dTSNJUn8Z8+WNA@mail.gmail.com>
	<CALj2ACUT+DB8PhF6ja8f-LP76cEappXrJuhzrKd81a90UmrnYA@mail.gmail.com>
	<CAOxo6XLhKqiacFPSo2BhZU6Qwwy3wDEsVjPmTsgHz9Pr-aVyUg@mail.gmail.com>
	<CAOxo6XJyYZdiEsF5r3+h1BSPprQ6+8=a4EgNiePWQjyFaafdZw@mail.gmail.com>
	<CALj2ACVwNiSNKFjZ+Wr2a+Wwqt9ELCQeFXTWNqf8s8eOZSd7Ew@mail.gmail.com>
	<[email protected]>
	<CALj2ACU2Owy6KhQ2sqWUt6MSyPXor4ha6p2BWoqf5v2_i2UB=Q@mail.gmail.com>

On Mon, Dec 26, 2022 at 04:18:18PM +0530, Bharath Rupireddy wrote:
> +1. I think this feature will also be useful in pg_walinspect.
> However, I'm a bit concerned that it can flood the running database
> disk - if someone generates a lot of FPI files.

pg_read_file() and pg_waldump can be fed absolute paths outside the
data folder.  So, well, just don't do that then :)
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
  download

view thread (55+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox