From: Bruce Momjian <bruce@momjian.us>
To: Noah Misch <noah@leadboat.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jelte Fennema <postgres@jeltef.nl>
Cc: Andres Freund <andres@anarazel.de>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Jesse Zhang <sbjesse@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: run pgindent on a regular basis / scripted manner
Date: Mon, 30 Jan 2023 15:42:09 -0500
Message-ID: <Y9groc0Nyy7SOROy@momjian.us> (raw)
In-Reply-To: <20230129010603.GA1677550@rfd.leadboat.com>
References: <1502504.1674433722@sss.pgh.pa.us>
<20230123011002.fzcaa3krql3mqsfn@awork3.anarazel.de>
<1509591.1674437376@sss.pgh.pa.us>
<1608158.1674486546@sss.pgh.pa.us>
<20230123173136.knn77pbuakhvjfgk@awork3.anarazel.de>
<Y874Fh0q4mkk1s22@momjian.us>
<CAGECzQTqoGHrePM_pwmhaM+J1XOygYjzFod4sf=PAt7J4A19Mw@mail.gmail.com>
<2238493.1674572097@sss.pgh.pa.us>
<Y9ArogF7c+UgPgq9@momjian.us>
<20230129010603.GA1677550@rfd.leadboat.com>
On Sat, Jan 28, 2023 at 05:06:03PM -0800, Noah Misch wrote:
> On Tue, Jan 24, 2023 at 02:04:02PM -0500, Bruce Momjian wrote:
> > On Tue, Jan 24, 2023 at 09:54:57AM -0500, Tom Lane wrote:
> > > As another example, the mechanisms we use to create the typedefs list
> > > in the first place are pretty squishy/leaky: they depend on which
> > > buildfarm animals are running the typedef-generation step, and on
> > > whether anything's broken lately in that code --- which happens on
> > > a fairly regular basis (eg [1]). Maybe that could be improved,
> > > but I don't see an easy way to capture the set of system-defined
> > > typedefs that are in use on platforms other than your own. I
> > > definitely do not want to go over to hand maintenance of that list.
> >
> > As I now understand it, we would need to standardize on a typedef list
> > at the beginning of each major development cycle, and then only allow
> > additions,
>
> Not to my knowledge. There's no particular obstacle to updating the list more
> frequently or removing entries.
We would need to re-pgindent the tree each time, I think, which would
cause disruption if we did it too frequently.
> > and the addition would have to include any pgindent affects
> > of the addition.
>
> Yes, a hook intended to enforce pgindent cleanliness should run tree-wide
> pgindent when the given commit(s) change the typedef list. typedef list
> changes essentially become another kind of refactoring that can yield merge
> conflicts. If your commit passed the pgindent check, rebasing it onto a new
> typedefs list may require further indentation changes. New typedefs don't
> tend to change a lot of old code, so I would expect this sort of conflict to
> be minor, compared to all the other sources of conflicts.
Agreed.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Embrace your flaws. They make you human, rather than perfect,
which you will never be.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bruce@momjian.us, noah@leadboat.com, tgl@sss.pgh.pa.us, postgres@jeltef.nl, andres@anarazel.de, pg@bowt.ie, magnus@hagander.net, alvherre@2ndquadrant.com, sfrost@snowman.net, sbjesse@gmail.com
Subject: Re: run pgindent on a regular basis / scripted manner
In-Reply-To: <Y9groc0Nyy7SOROy@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox