pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
Subject: Re: recovery modules
Date: Thu, 2 Feb 2023 14:34:17 +0900
Message-ID: <Y9tLWcninCsugVMP@paquier.xyz> (raw)
In-Reply-To: <20230201212326.GA3593344@nathanxps13>
References: <20230128062729.GA2570237@nathanxps13>
	<Y9d3Cmk0Vjg8cYmO@paquier.xyz>
	<20230130194810.6fztfgbn32e7qarj@awork3.anarazel.de>
	<20230130200422.GA2797238@nathanxps13>
	<Y9hPBxfiN3m8hfs/@paquier.xyz>
	<20230131233013.GA3146744@nathanxps13>
	<20230201115426.6japkd3rfs36hbhk@alap3.anarazel.de>
	<20230201201529.GA3551058@nathanxps13>
	<20230201210606.nvfbuvzfby3gskvu@alap3.anarazel.de>
	<20230201212326.GA3593344@nathanxps13>

On Wed, Feb 01, 2023 at 01:23:26PM -0800, Nathan Bossart wrote:
> Yeah, that's nicer.  cfbot is complaining about a missing #include, so I
> need to send a new revision anyway.

Okay, the changes done here look straight-forward seen from here.  I
got one small-ish comment.

+basic_archive_startup(ArchiveModuleState *state)
+{
+   BasicArchiveData *data = palloc0(sizeof(BasicArchiveData));

Perhaps this should use MemoryContextAlloc() rather than a plain
palloc().  This should not matter based on the position where the
startup callback is called, still that may be a pattern worth
encouraging.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (90+ messages)  latest in thread

Message-ID: <Y9tLWcninCsugVMP@paquier.xyz>
Permalink:  ../Y9tLWcninCsugVMP@paquier.xyz/
Also on:    postgresql.org/message-id/Y9tLWcninCsugVMP@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, nathandbossart@gmail.com, andres@anarazel.de
  Subject: Re: recovery modules
  In-Reply-To: <Y9tLWcninCsugVMP@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox