From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Ian Lawrence Barwick <barwick@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] remove pg_standby
Date: Wed, 27 Jan 2021 14:06:35 +0900
Message-ID: <YBD02x3LL/lge59J@paquier.xyz> (raw)
In-Reply-To: <CA+hUKGLrL42NSc-yKVvtGVg_=1zq8NFysy-xg1=4DShFsFVB9g@mail.gmail.com>
References: <20201029024412.GP5380@telsasoft.com>
<3de458c1-2299-92a8-1fa1-d59ac385140c@enterprisedb.com>
<20201121194105.GO24784@telsasoft.com>
<47c1a857-3e42-489d-6be3-ee229f970d0c@enterprisedb.com>
<CA+hUKGLrL42NSc-yKVvtGVg_=1zq8NFysy-xg1=4DShFsFVB9g@mail.gmail.com>
On Wed, Jan 27, 2021 at 04:13:24PM +1300, Thomas Munro wrote:
> I would like to commit this, because "waiting restore commands" have
> confusing interactions with my proposed prefetching-during-recovery
> patch[1]. Here's a version that fixes an error when building the docs
> (there was a stray remaining <xref linkend="pgstandby"/>), and adds a
> commit message. Any objections?
It looks like you are missing two references in your patch set:
$ git grep pg_standby
doc/src/sgml/high-availability.sgml: Do not use pg_standby or
similar tools with the built-in standby mode
src/backend/access/transam/xlog.c: * segment. Only recycle normal
files, pg_standby for example can create
The logic assumed in RemoveXlogFile() is actually a bit scary. I have
not checked in details but it could be possible to clean up more code
in this area?
> Furthermore, I think we should also remove the section of the manual
> that describes how to write your own "waiting restore command".
> Thoughts?
Agreed. No objections to that.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, thomas.munro@gmail.com, peter.eisentraut@enterprisedb.com, pryzby@telsasoft.com, hlinnaka@iki.fi, tgl@sss.pgh.pa.us, sfrost@snowman.net, barwick@gmail.com
Subject: Re: [PATCH] remove pg_standby
In-Reply-To: <YBD02x3LL/lge59J@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox