From: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org, Bruce Momjian <bruce@momjian.us>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Subject: Re: doc review for v14
Date: Thu, 25 Feb 2021 17:05:27 +0900
Message-ID: <YDdaR29pDIXpGTBQ@paquier.xyz> (raw)
In-Reply-To: <20210224073955.GH14772@telsasoft.com>
References: <20201222041153.GK30237@telsasoft.com>
<X+RNUu+zotOjfL7K@paquier.xyz>
<20201227202604.GC26311@telsasoft.com>
<YAv3TG9fOrNXxJoK@paquier.xyz>
<YBD/jjCqGoSFeUWW@paquier.xyz>
<YBO6ZGbYRoc5Rkra@paquier.xyz>
<20210210235557.GQ20012@telsasoft.com>
<20210222080345.GA23313@telsasoft.com>
<YDX924cg0EKAgW8v@paquier.xyz>
<20210224073955.GH14772@telsasoft.com>
On Wed, Feb 24, 2021 at 01:39:55AM -0600, Justin Pryzby wrote:
> On Wed, Feb 24, 2021 at 04:18:51PM +0900, Michael Paquier wrote:
>> + The status of each kind of extended statistics is shown in a column
>> + named after the "kind" (e.g. Ndistinct).
>> + NULL means that it doesn't exist. "defined" means that it was requested
>> From 0009, there is a grammar mistake on HEAD here, but I don't
>> understand what you mean by "kind" here. Wouldn't it be better to not
>> use quotes and just refer to "its type of statistics"?
>
> I mean stxkind. "type" doesn't mean anything.
How would you reword that then?
> - vacuum the main relation. This option is required when the
> + vacuum the main relation. This option may not be disabled when the
> <literal>FULL</literal> option is used.
>
> "This option is required.." sounds like "this option must be specified", which
> is wrong.
Hmm. Wouldn't it be better to say then "this option cannot be
disabled when FULL is used"?
> When creating an index on a partitioned table, this column is set to
> - the number of partitions on which the index has been completed.
> + the number of partitions on which the index has been created.
>
> What is index "completion" ?
Done with. Perhaps Alvaro has a comment to offer here as this comes
from ab0dfc9.
> This is very
> - convenient, as not only will the existing partitions become indexed, but
> - also any partitions that are created in the future will. One limitation is
> + convenient, as not only the existing partitions will be indexed, but
> + so will any partitions that are created in the future. One limitation is
>
> "become indexed" sounds strange (and vague), and "will." is additionally awkward.
Not that strange to me (see dbca945).
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, pryzby@telsasoft.com, bruce@momjian.us, thomas.munro@gmail.com, alvherre@2ndquadrant.com
Subject: Re: doc review for v14
In-Reply-To: <YDdaR29pDIXpGTBQ@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox