From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Jaime Casanova <jcasanov@systemguards.com.ec>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: SQL-standard function body
Date: Thu, 8 Apr 2021 16:54:56 +0900
Message-ID: <YG620HiF8Huz/YIn@paquier.xyz> (raw)
In-Reply-To: <20210408063514.houn2s3yxcorukdf@alap3.anarazel.de>
References: <20210331101256.d7h7d74o4celskt4@nol>
<9277ef6a-bfa8-9c06-8e91-16c2892120cc@2ndquadrant.com>
<20210403033943.dp6um65shvrovoj5@nol>
<01c65ea6-e5bf-22f4-cacc-6d0f6853a965@2ndquadrant.com>
<1646498.1617826937@sss.pgh.pa.us>
<YG54YggzyPrTFE+e@paquier.xyz>
<1819824.1617858962@sss.pgh.pa.us>
<20210408052759.7bmyawm4djnrux6y@alap3.anarazel.de>
<1820954.1617860500@sss.pgh.pa.us>
<20210408063514.houn2s3yxcorukdf@alap3.anarazel.de>
On Wed, Apr 07, 2021 at 11:35:14PM -0700, Andres Freund wrote:
> On 2021-04-08 01:41:40 -0400, Tom Lane wrote:
>> Andres Freund <andres@anarazel.de> writes:
>> FWIW, I think the long-term drift of things is definitely that
>> we want to have the querystring available everywhere. Code like
>> executor_errposition is from an earlier era before we were trying
>> to enforce that. In particular, if the querystring is available in
>> the leader and not the workers, then you will get different error
>> reporting behavior in parallel query than non-parallel query, which
>> is surely a bad thing.
>
> Yea, I think it's a sensible direction - but I think we should put the
> line in the sand earlier on / higher up than ExecInitParallelPlan().
Indeed, I agree that enforcing the availability of querystring
everywhere sounds like a sensible thing to do in terms of consistency,
and that's my impression when I scanned the parallel execution code,
and I don't really get why SQL function bodies should not bind by this
rule. Would people object if I add an open item to track that?
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, andres@anarazel.de, tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, rjuju123@gmail.com, jcasanov@systemguards.com.ec
Subject: Re: SQL-standard function body
In-Reply-To: <YG620HiF8Huz/YIn@paquier.xyz>
References: <20210331101256.d7h7d74o4celskt4@nol> <9277ef6a-bfa8-9c06-8e91-16c2892120cc@2ndquadrant.com> <20210403033943.dp6um65shvrovoj5@nol> <01c65ea6-e5bf-22f4-cacc-6d0f6853a965@2ndquadrant.com> <1646498.1617826937@sss.pgh.pa.us> <YG54YggzyPrTFE+e@paquier.xyz> <1819824.1617858962@sss.pgh.pa.us> <20210408052759.7bmyawm4djnrux6y@alap3.anarazel.de> <1820954.1617860500@sss.pgh.pa.us> <20210408063514.houn2s3yxcorukdf@alap3.anarazel.de> <YG620HiF8Huz/YIn@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox