From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Move pg_attribute.attcompression to earlier in struct for reduced size?
Date: Thu, 10 Jun 2021 11:09:52 +0900
Message-ID: <YMF0cDCFxe4w3bTx@paquier.xyz> (raw)
In-Reply-To: <1264790.1623209541@sss.pgh.pa.us>
References: <YLw797TlZxbB0QHU@paquier.xyz>
<202106081439.m2pwwk5yvcrd@alvherre.pgsql>
<YMA0iRYL49kdCCZu@paquier.xyz>
<1264790.1623209541@sss.pgh.pa.us>
On Tue, Jun 08, 2021 at 11:32:21PM -0400, Tom Lane wrote:
> I can imagine sometime in the future where we need to get rid of all
> instances of pglz so we can reassign that compression code to something
> else. But would we insist on a mass VACUUM FULL to make that happen?
> Doubt it. You'd want a tool that would make that happen over time,
> in the background; like the mechanisms that have been discussed for
> enabling checksums on-the-fly.
Well, I can imagine that some people could afford being more
aggressive here even if it implies some downtime and if they are not
willing to afford the deployment of a second instance for a
dump/restore or a logirep setup.
(The parallel with data checksums is partially true, as you can do a
switch of checksums with physical replication as the page's checksums
are only written when pushed out of shared buffers, not when they are
written into WAL. This needs a second instance, of course.)
> In the meantime I'm +1 for dropping this logic from VACUUM FULL.
> I don't even want to spend enough more time on it to confirm the
> different overhead measurements that have been reported.
Agreed. It looks like we are heading toward doing just that for this
release.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, robertmhaas@gmail.com, dilipbalaut@gmail.com, andres@anarazel.de
Subject: Re: Move pg_attribute.attcompression to earlier in struct for reduced size?
In-Reply-To: <YMF0cDCFxe4w3bTx@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox