pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: gkokolatos@pm.me
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Andrew Dunstan <andrew@dunslane.net>
Subject: Re: Introduce pg_receivewal gzip compression tests
Date: Tue, 20 Jul 2021 13:31:30 +0900
Message-ID: <YPZRorFpKMrKp2KP@paquier.xyz> (raw)
In-Reply-To: <YPUjxaIWkHUzBdwg@paquier.xyz>
References: <3NaNnzcFOo6mMA50bGVOS7RNlz1IqJ8nBxvMRQw9UZFUu9zSK2taKcmmrI2B0dehIXVskeCtbtA5yTnpkPGBTJvD-55DqTjRR-nji7tML68=@pm.me>
	<YO5H18MUJV+EMnR7@paquier.xyz>
	<icWOHz3LswZT-5mwtCbM8RHnhscksmm2gMw8BeejAoXyh9VWCiA2_jEpyGbv53HgrlZXf1F7Sb4nmxFeO5TxBTSRY6NH30RH83hDAgMHpZQ=@pm.me>
	<YO/coGVNAZTARxEw@paquier.xyz>
	<UEfDrva3Z-7dBiFYyj9Di0C-Ms1E2rbBCfgmgeP--2knm3ij4KddMN56vmtRlL_pp4CIYGhw_uaccoTjVBsTsk7xS4VHe-93TKg2tQb4JM0=@pm.me>
	<YPAdf9r5aJbDoHoq@paquier.xyz>
	<YPArqBhngZZkzs1x@paquier.xyz>
	<YPDLz2x3o1aX2wRh@paquier.xyz>
	<YPEUaebGdNT1CFdx@paquier.xyz>
	<YPUjxaIWkHUzBdwg@paquier.xyz>

On Mon, Jul 19, 2021 at 04:03:33PM +0900, Michael Paquier wrote:
> Another advantage of this patch is the handling of ".gz" is reduced to
> one code path instead of four.  That makes a bit easier the
> introduction of new compression methods.
> 
> A second thing that was really confusing is that the name of the WAL
> segment generated in this code path completely ignored the type of
> compression.  This led to one confusing error message if failing to
> open a segment for write where we'd mention a .partial file rather
> than a .gz.partial file.  The versions of zlib I used on Windows
> looked buggy so I cannot conclude there, but I am sure that this
> should allow bowerbird to handle the test correctly.

After more testing and more review, I have applied and backpatched
this stuff.  Another thing I did on HEAD was to enable again the ZLIB
portion of the pg_receivewal tests on Windows.  bowerdird should stay
green (I hope), and it is better to have as much more coverage as
possible for all that.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (29+ messages)

Message-ID: <YPZRorFpKMrKp2KP@paquier.xyz>
Permalink:  ../YPZRorFpKMrKp2KP@paquier.xyz/
Also on:    postgresql.org/message-id/YPZRorFpKMrKp2KP@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, gkokolatos@pm.me, pgsql-hackers@lists.postgresql.org, andrew@dunslane.net
  Subject: Re: Introduce pg_receivewal gzip compression tests
  In-Reply-To: <YPZRorFpKMrKp2KP@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox