pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Anastasia Lubennikova <lubennikovaav@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: A test for replay of regression tests
Date: Wed, 15 Dec 2021 17:50:45 +0900
Message-ID: <YbmsZbEO1QGMymNF@paquier.xyz> (raw)
In-Reply-To: <CA+hUKGJd_BSh_6hNCDPfvEcRDk6g7gYxybEvVuGgFWe+D3useA@mail.gmail.com>
References: <CA+hUKGKwH-mDeReafALoR5Ui5MVM_HKjyskbkMh+U=6oKk+E3w@mail.gmail.com>
	<CA+hUKG+stUD8qE6s5uJPpFaTW-5ZADp+Bq2Bhiu+-00j3xz7gg@mail.gmail.com>
	<CA+hUKGK=FdtCWjx5eqJ8DVtOoAT2W9os+DYNT3Z9MjX-iaa8zA@mail.gmail.com>
	<1f2ea615-2c26-633d-5018-19e4315f84d3@dunslane.net>
	<e05b213c-1257-84d4-f079-5c4d8c79e3ad@dunslane.net>
	<CA+hUKG+nk_WCqi_y+9TentqwXvy=1dW0DgBB-8yTtgdTTLtP0Q@mail.gmail.com>
	<3e9d1044-ddb2-91a4-917b-8cab3ea93b69@dunslane.net>
	<CA+hUKGLnJoeSqtp0tNyFj2GUYaNgbCQ3KTZqCfFH7QY2+Ojcdg@mail.gmail.com>
	<20211209213605.6lwb7o2kzdla34qk@alap3.anarazel.de>
	<CA+hUKGJd_BSh_6hNCDPfvEcRDk6g7gYxybEvVuGgFWe+D3useA@mail.gmail.com>

On Fri, Dec 10, 2021 at 12:58:01PM +1300, Thomas Munro wrote:
> -# required for 017_shm.pl
> +# required for 017_shm.pl and 027_stream_regress.pl
>  REGRESS_SHLIB=$(abs_top_builddir)/src/test/regress/regress$(DLSUFFIX)
>  export REGRESS_SHLIB

Hmm.  FWIW, I am working on doing similar for pg_upgrade to switch to
TAP there, and we share a lot in terms of running pg_regress on an
exising cluster.  Wouldn't it be better to move this definition to
src/Makefile.global.in rather than src/test/recovery/?

My pg_regress command is actually very similar to yours, so I am
wondering if this would be better if somehow centralized, perhaps in
Cluster.pm.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (82+ messages)  latest in thread

Message-ID: <YbmsZbEO1QGMymNF@paquier.xyz>
Permalink:  ../YbmsZbEO1QGMymNF@paquier.xyz/
Also on:    postgresql.org/message-id/YbmsZbEO1QGMymNF@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, thomas.munro@gmail.com, andres@anarazel.de, andrew@dunslane.net, lubennikovaav@gmail.com, tgl@sss.pgh.pa.us
  Subject: Re: A test for replay of regression tests
  In-Reply-To: <YbmsZbEO1QGMymNF@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox