public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Robert Haas <[email protected]>
Cc: Justin Pryzby <[email protected]>
Cc: Georgios <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Rachel Heaton <[email protected]>
Subject: Re: Add LZ4 compression in pg_dump
Date: Wed, 30 Mar 2022 15:36:02 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+TgmoYd2XBJ_vzHUKwR6u+usmNNQvz+2J+ZDWhrMYXCGGP2Fw@mail.gmail.com>
References: <faUNEOpts9vunEaLnmxmG-DldLSg_ql137OC3JYDmgrOMHm1RvvWY2IdBkv_CRxm5spCCb_OmKNk2T03TMm0fBEWveFF9wA1WizPuAgB7Ss=@protonmail.com>
<[email protected]>
<CA+TgmoZJyx7anpGsZbOgpcP6RmyJ1-kWoKuuCYJsNohRVbOmGQ@mail.gmail.com>
<[email protected]>
<CA+Tgmob5COx7=e69vXk3OajAg_SwpAf8KKdGABToP9ms+UXErw@mail.gmail.com>
<[email protected]>
<CA+TgmoYd2XBJ_vzHUKwR6u+usmNNQvz+2J+ZDWhrMYXCGGP2Fw@mail.gmail.com>
On Tue, Mar 29, 2022 at 09:14:03AM -0400, Robert Haas wrote:
> I don't know what you mean by this. I think the specification stuff
> could be reused in a lot of places. If you can ask for a base backup
> with zstd:level=3,long=1,fancystuff=yes or whatever we end up with,
> why not enable exactly the same for every other place that uses
> compression? I don't know what "client-server requirements" is or what
> that has to do with this.
Oh. I think that I got confused here. I saw the backup component in
the file name and this has been associated with the client/server
choice that can be done in the options of pg_basebackup. But
parse_bc_specification() does not include any knowledge about that:
pg_basebackup does this job in parse_compress_options(). I agree that
it looks possible to reuse that stuff in more places than just base
backups.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (69+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Add LZ4 compression in pg_dump
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox