public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Robert Haas <[email protected]>
Cc: Postgres hackers <[email protected]>
Cc: Georgios <[email protected]>
Subject: Re: Fixes for compression options of pg_receivewal and refactoring of backup_compression.{c,h}
Date: Tue, 12 Apr 2022 07:50:29 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+TgmoabKxkyZ5oY8TXb7ZAUC6gsRA1ojMM0+TUZbR61HEUvog@mail.gmail.com>
References: <[email protected]>
<CA+TgmoabKxkyZ5oY8TXb7ZAUC6gsRA1ojMM0+TUZbR61HEUvog@mail.gmail.com>
On Mon, Apr 11, 2022 at 11:15:46AM -0400, Robert Haas wrote:
> +1 for this in general, but I think that naming like
> "compression_algo" stinks. If you think "compression_algorithm" is too
> long, I think you should use "algorithm" or "compression" or
> "compression_method" or something.
Yes, I found "compression_algorithm" to be too long initially. For
walmethods.c and pg_receivewal.c, it may be better to just stick to
"algorithm" then, at least that's consistent with pg_basebackup.c.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (11+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Fixes for compression options of pg_receivewal and refactoring of backup_compression.{c,h}
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox