public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: [email protected]
Cc: Postgres hackers <[email protected]>
Cc: Robert Haas <[email protected]>
Subject: Re: Fixes for compression options of pg_receivewal and refactoring of backup_compression.{c,h}
Date: Thu, 14 Apr 2022 06:18:29 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <QYtEfeZ2bTdYAeqCR-5rQs_myRhJclxaVfun-OEVSPnauawRqris5UNUTnYtoFy_KnhCbsjtkEeoxvZgLT0UkZTMnMq65BOwklSwFqbvI1U=@pm.me>
References: <[email protected]>
<Pw7ltgmMRlWiJ8w3EW_1Paoeaf1QIJtV-c-U9UgF8f12w3wxpFbqwp97hr3OchnlOFetTA50zYcMQ3coWDutqP3a1qsG2SXOKipKY3lNqBE=@pm.me>
<[email protected]>
<[email protected]>
<QYtEfeZ2bTdYAeqCR-5rQs_myRhJclxaVfun-OEVSPnauawRqris5UNUTnYtoFy_KnhCbsjtkEeoxvZgLT0UkZTMnMq65BOwklSwFqbvI1U=@pm.me>
On Wed, Apr 13, 2022 at 02:58:28PM +0000, [email protected] wrote:
> It's really not hard to add compression level. However we had briefly
> discussed it in the original thread [1] and decided against. That is why
> I did not write that code. If the community thinks differently now, let
> me know if you would like me to offer a patch for it.
The issue back then was how to design the option set to handle all
that (right? My memories may be short on that), and pg_basebackup
takes care of that with its option design.
This is roughly what has been done here, except that this was for the
contentSize:
https://www.postgresql.org/message-id/rYyZ3Fj9qayyY9-egNsV_kkLbL_BSWcOEdi3Mb6M9eQRTkcA2jrqFEHglLUEYn...
Do you think that the extra test coverage is going to be too much of a
burden? I was thinking about just adding a level to the main lz4
command, with an extra negative test in the SKIP block with a level
out of range
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (9+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Fixes for compression options of pg_receivewal and refactoring of backup_compression.{c,h}
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox