pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Bruce Momjian <bruce@momjian.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: First draft of the PG 15 release notes
Date: Wed, 11 May 2022 10:32:21 -0400
Message-ID: <YnvI9eanyeYMXws/@momjian.us> (raw)
In-Reply-To: <CAApHDvo57tuCk=L_=_Q0mvmBxUYi+aoZZ6HtxmYM9cg7euX_KA@mail.gmail.com>
References: <YnqIT8kpiO3m6SD7@momjian.us>
	<CAApHDvq5sZo2Ueu6-yViAVonagTeLMnbMWY9DFcFC3onc8j-uw@mail.gmail.com>
	<YnsZSTrHK9AS7qwe@momjian.us>
	<CAApHDvo57tuCk=L_=_Q0mvmBxUYi+aoZZ6HtxmYM9cg7euX_KA@mail.gmail.com>

On Wed, May 11, 2022 at 02:31:08PM +1200, David Rowley wrote:
> On Wed, 11 May 2022 at 14:02, Bruce Momjian <bruce@momjian.us> wrote:
> >
> > On Wed, May 11, 2022 at 12:39:41PM +1200, David Rowley wrote:
> > > I think the sort improvements done in v15 are worth a mention under
> > > General Performance.  The commits for this were 91e9e89dc, 40af10b57
> > > and 697492434.  I've been running a few benchmarks between v14 and v15
> > > over the past few days and a fairly average case speedup is about 25%.
> > > but there are cases where I've seen up to 400%.  I think the increase
> > > is to an extent that we maybe should have considered making tweaks in
> > > cost_tuplesort(). I saw some plans that ran in about 60% of the time
> > > by disabling Hash Agg and allowing Sort / Group Agg to do the work.
> >
> > Good point.  Do you have any suggested text?  I can't really see it
> > clearly based on the commits, except "sorting is faster".
> 
> If we're going to lump those into a single line then maybe something
> along the lines of:
> 
> * Reduce memory consumption and improve performance of sorting tuples in memory
> 
> I think one line is fine from a user's perspective, but it's slightly
> harder to know the order of the names in the credits given the 3
> independent commits.

Okay, I went with this:

	<!--
	Author: David Rowley <drowley@postgresql.org>
	2021-07-22 [91e9e89dc] Make nodeSort.c use Datum sorts for single column sorts
	Author: David Rowley <drowley@postgresql.org>
	2022-04-04 [40af10b57] Use Generation memory contexts to store tuples in sorts
	Author: John Naylor <john.naylor@postgresql.org>
	2022-04-02 [697492434] Specialize tuplesort routines for different kinds of abb
	-->
	
	<listitem>
	<para>
	Improve performance and reduce memory consumption of in-memory
	sorts (Ronan Dunklau, David Rowley, Thomas Munro)
	</para>
	</listitem>

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Indecision is a decision.  Inaction is an action.  Mark Batterson






view thread (145+ messages)  latest in thread

Message-ID: <YnvI9eanyeYMXws/@momjian.us>
Permalink:  ../YnvI9eanyeYMXws%2F@momjian.us/
Also on:    postgresql.org/message-id/YnvI9eanyeYMXws/@momjian.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: bruce@momjian.us, dgrowleyml@gmail.com
  Subject: Re: First draft of the PG 15 release notes
  In-Reply-To: <YnvI9eanyeYMXws/@momjian.us>
  References: <YnqIT8kpiO3m6SD7@momjian.us> <CAApHDvq5sZo2Ueu6-yViAVonagTeLMnbMWY9DFcFC3onc8j-uw@mail.gmail.com> <YnsZSTrHK9AS7qwe@momjian.us> <CAApHDvo57tuCk=L_=_Q0mvmBxUYi+aoZZ6HtxmYM9cg7euX_KA@mail.gmail.com> <YnvI9eanyeYMXws/@momjian.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox