public inbox for [email protected]  

help / color / mirror / Atom feed

From: Sandro Santilli <[email protected]>
To: Laurenz Albe <[email protected]>
Cc: Regina Obe <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] Support % wildcard in extension upgrade filenames
Date: Sat, 4 Jun 2022 11:20:55 +0200
Message-ID: <Ypsj95RJSARwfQt6@c19> (raw)
In-Reply-To: <[email protected]>
References: <YgakFklJyM5pNdt+@c19>
	<[email protected]>
	<[email protected]>

On Sat, May 28, 2022 at 04:50:20PM +0200, Laurenz Albe wrote:
> On Fri, 2022-05-27 at 17:37 -0400, Regina Obe wrote:
> >
> > https://lists.osgeo.org/pipermail/postgis-devel/2022-February/029500.html
> > 
> > Does anyone think this is such a horrible idea that we should abandon all
> > hope?
> 
> I don't think this idea is fundamentally wrong, but I have two worries:
> 
> 1. It would be a good idea good to make sure that there is not both
>    "extension--%--2.0.sql" and "extension--1.0--2.0.sql" present.
>    Otherwise the behavior might be indeterministic.

I'd make sure to use extension--1.0--2.0.sql in that case (more
specific first).

> 2. What if you have a "postgis--%--3.3.sql", and somebody tries to upgrade
>    their PostGIS 1.1 installation with it?  Would that work?

For PostGIS in particular it will NOT work as the PostGIS upgrade
script checks for the older version and decides if the upgrade is
valid or not. This is the same upgrade code used for non-extension
installs.

>    Having a lower bound for a matching version might be a good idea,
>    although I have no idea how to do that.

I was thinking of a broader pattern matching support, like:

  postgis--3.%--3.3.sql

But it would be better to start simple and eventually if needed
increase the complexity ?

Another option could be specifying something in the control file,
which would also probably be a good idea to still allow some
extensions to use '%' in the version string (for example).

--strk; 

  Libre GIS consultant/developer
  https://strk.kbt.io/services.html

view thread (24+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Support % wildcard in extension upgrade filenames
  In-Reply-To: <Ypsj95RJSARwfQt6@c19>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox