From: Christoph Berg <myon@debian.org>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_receivewal and SIGTERM
Date: Fri, 19 Aug 2022 12:54:34 +0200
Message-ID: <Yv9r6s815aba836p@msg.df7cb.de> (raw)
In-Reply-To: <CALj2ACW1LTGaBbhF=E0gmavPYsbNmGdpVu+S6vd3U+93mYnUsw@mail.gmail.com>
References: <Yvo/5No5S0c4EFMj@msg.df7cb.de>
<EC39E60E-C8B6-4CDF-8BFA-E4D140446B41@yesql.se>
<YvuBL1tvlSNiFQUB@msg.df7cb.de>
<15338147-16C0-4D4D-8CAD-460102857BF6@yesql.se>
<CALj2ACVTxZg_B5KTFbDYNKbP2=SXhxBWvopvK04eT0UvDsDckg@mail.gmail.com>
<YvuiHaqzde5FJEIC@msg.df7cb.de>
<CALj2ACW1LTGaBbhF=E0gmavPYsbNmGdpVu+S6vd3U+93mYnUsw@mail.gmail.com>
Re: Bharath Rupireddy
> <application>pg_receivewal</application> will exit with status 0 when
> - terminated by the <systemitem>SIGINT</systemitem> signal. (That is the
> + terminated by the <systemitem>SIGINT</systemitem> or
> + <systemitem>SIGTERM</systemitem> signal. (That is the
> normal way to end it. Hence it is not an error.) For fatal errors or
> other signals, the exit status will be nonzero.
>
> Can we specify the reason in the docs why a SIGTERM causes (which
> typically would cause a program to end with non-zero exit code)
> pg_receivewal and pg_recvlogical exit with zero exit code? Having this
> in the commit message would help developers but the documentation will
> help users out there.
We could add "because you want that if it's running as a daemon", but
TBH, I'd rather remove the parentheses part. It sounds too much like
"it works that way because that way is the sane way".
Christoph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: myon@debian.org, bharath.rupireddyforpostgres@gmail.com, daniel@yesql.se, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_receivewal and SIGTERM
In-Reply-To: <Yv9r6s815aba836p@msg.df7cb.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox