From: Nathan Bossart <nathandbossart@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
Cc: dipiets@amazon.com
Subject: Re: use a non-locking initial test in TAS_SPIN on AArch64
Date: Fri, 10 Jan 2025 10:51:40 -0600
Message-ID: <Z4FQHBrAiFXhE4ZM@nathan> (raw)
In-Reply-To: <Z37-Svaqt7XCBcXP@nathan>
References: <ZxgDEb_VpWyNZKB_@nathan>
<Z37AA6-SsJoLaifa@nathan>
<tdex7aj3zrvdu22dfgtljbrybrjezbjpr374otnadi6qxywkmc@rzxtb2fbubpy>
<Z371r_AVOU0WCrBr@nathan>
<tb6d2bg5a3so2325opkaow3ptkvpgpxzz3nnkehb3x7d77g3sx@xjid7uptuoni>
<Z37-Svaqt7XCBcXP@nathan>
On Wed, Jan 08, 2025 at 04:38:02PM -0600, Nathan Bossart wrote:
> On Wed, Jan 08, 2025 at 05:25:24PM -0500, Andres Freund wrote:
>> I wonder if you're hitting an extreme case of binary-layout related effects?
>> I've never seen them at this magnitude though. I'd suggest using either lld
>> or mold as linker and comparing the numbers for a few
>> -Wl,--shuffle-sections=$seed seed values.
>
> Will do.
Actually, I think I may have just had back luck and/or not warmed things up
enough. I just re-ran the test a few dozen times, carefully ensuring the
data was in the cache and periodically alternating between the binary with
the patch applied and the one without it. The results converged to within
1-2% of each other, with the patched version even winning about half the
time. The averages across all the runs showed a ~0.4% regression, which I
suspect is well within the noise range.
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, andres@anarazel.de, dipiets@amazon.com
Subject: Re: use a non-locking initial test in TAS_SPIN on AArch64
In-Reply-To: <Z4FQHBrAiFXhE4ZM@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox