public inbox for [email protected]  

help / color / mirror / Atom feed

From: Michael Paquier <[email protected]>
To: Dagfinn Ilmari Mannsåker <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: pg_createsubscriber TAP test wrapping makes command options hard to read.
Date: Wed, 22 Jan 2025 14:50:47 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAHut+PuD0aQfjAN0q_7FpdNdSEdrhONpTsb0tQi5ZEtZHj6bKg@mail.gmail.com>
	<[email protected]>
	<CAHut+PvKrQXY7kM8ct=HC9xYPC6yhdJWnvCgijtgxmO-mus8uQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>

On Tue, Jan 21, 2025 at 02:17:03PM +0000, Dagfinn Ilmari Mannsåker wrote:
> Thanks again for reviewing this monster patch.

+$node->command_checks_all(
+   [ 'pg_amcheck', '--exclude-user' => 'no_such_user', 'postgres' ],

Extra error spotted here with s/--exclude-user/--username/.

The double --verbose for test 'run pg_createsubscriber on node S' is
intentional, as mentioned by Euler.  Fixed this one by making the two
--verbose be side-by-side, and added a comment to document the
intention.

Perhaps pg_resetwal/t/001_basic.pl should also use more long option
names?  Note that there are a few more under "Locale provider
tests" in the initdb tests.  I've left that as a follow-up thing,
that was already a lot..

Found some more inconsistencies with the ordering of the options, like
a few start commands with pg_ctl in the recovery tests.  I've
maintained some consistency here, even if your patch was OK.
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
  download

view thread (11+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pg_createsubscriber TAP test wrapping makes command options hard to read.
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox