From: Nathan Bossart <nathandbossart@gmail.com>
To: Noah Misch <noah@leadboat.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>
Cc: Robert Pang <robertpang@google.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: robertmhaas@gmail.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: Back-patch of: avoid multiple hard links to same WAL file after a crash
Date: Thu, 6 Mar 2025 13:44:30 -0600
Message-ID: <Z8n7HopB0bb4_j19@nathan> (raw)
In-Reply-To: <20250306193013.36.nmisch@google.com>
References: <Ym+28lDf5sCJ6pAj@paquier.xyz>
<20220502173907.GB3351307@nathanxps13>
<20220502230613.GA3398932@nathanxps13>
<YnOwioN/mo6k1Dtb@paquier.xyz>
<YsORtfT4+fXj/i1V@paquier.xyz>
<CAJhEC04tBkYPF4q2uS_rCytauvNEVqdBAzasBEokfceFhF=KDQ@mail.gmail.com>
<Z2L6e1w-xABVTBRR@nathan>
<7chjz7zeigbsbt7nim4cj6zryflzcpy2lgenas3yh7cpvwf3gb@m6cwqzlvfd6q>
<Z2Oy1Z2nMVmTM5L5@paquier.xyz>
<20250306193013.36.nmisch@google.com>
On Thu, Mar 06, 2025 at 11:30:13AM -0800, Noah Misch wrote:
> Options I see:
>
> 1. Make v14 and v13 skip WAL recycling and preallocation during archive
> recovery, like newer branches do. I think that means back-patching the six
> commits cc2c7d6~4 cc2c7d6~3 cc2c7d6~2 cc2c7d6~1 cc2c7d6 e36cbef.
>
> 2. Revert 1f95181b44c843729caaa688f74babe9403b5850 and its v13 counterpart.
> Avoid multiple hard links by making durable_rename_excl() first rename
> oldfile to a temporary name. (I haven't thought this through in detail.
> It may not suffice.)
>
> I'm leaning toward (1) at least enough to see how messy the back-patch would
> be, since I don't like risks of designing old-branch-specific solutions when
> v15/v16/v17 have a proven solution. What else should we be thinking about
> before deciding?
I agree with first attempting a back-patch. All of this stuff is from
2021-2022, so it's had time to bake and is IMHO lower risk.
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, noah@leadboat.com, michael@paquier.xyz, andres@anarazel.de, robertpang@google.com, horikyota.ntt@gmail.com, tgl@sss.pgh.pa.us, robertmhaas@gmail.com
Subject: Re: Back-patch of: avoid multiple hard links to same WAL file after a crash
In-Reply-To: <Z8n7HopB0bb4_j19@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox