pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Jacob Champion <jchampion@timescale.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Aleksander Alekseev <aleksander@timescale.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Subject: Re: [PoC] Let libpq reject unexpected authentication requests
Date: Tue, 14 Mar 2023 14:39:07 +0900
Message-ID: <ZBAIe1gnGxknLT7t@paquier.xyz> (raw)
In-Reply-To: <CAAWbhmg+GzNMK5Li182BKSbzoFVaKk_dDJ628NnuV80GqYgFFg@mail.gmail.com>
References: <Y9ms6HPSxEiXpw+4@paquier.xyz>
	<CAAWbhmihPDBe+sHPxY0N+9YUj8MoRErdeSYjMeiic0evLWYtmQ@mail.gmail.com>
	<add8d351-1a03-378b-d8fa-9e2aa04bd0be@timescale.com>
	<ZAKucp7m0purD2cm@paquier.xyz>
	<CAAWbhmjRHYG_HN-yuej5Q7tUYuViodXm7BusjUkUyv2fW-+KPQ@mail.gmail.com>
	<ZAl+Lj+4Q8+aHimx@paquier.xyz>
	<c136387c-731e-729b-a49f-c1f17768aaf0@timescale.com>
	<ZAu4rdSKQTHvBqS7@paquier.xyz>
	<CAAWbhmgNoAp2gfdzrH0BmYbmsMo-k4FjN2OAhtLm0VjaS_9=Cg@mail.gmail.com>
	<CAAWbhmg+GzNMK5Li182BKSbzoFVaKk_dDJ628NnuV80GqYgFFg@mail.gmail.com>

On Mon, Mar 13, 2023 at 12:38:10PM -0700, Jacob Champion wrote:
> Here's a v16:
> - updated 0001 patch message
> - all test names should have commas rather than colons now
> - new test for an empty require_auth
> - new SSPI suite (note that it doesn't run by default on Cirrus, due
> to the use of PG_TEST_USE_UNIX_SOCKETS)
> - fixed errant comma at EOL

0001 was looking fine enough seen from here, so applied it after
tweaking a few comments.  That's enough to cover most of the needs of
this thread.

0002 looks pretty simple as well, I think that's worth a look for this
CF.  I am not sure about 0003, to be honest, as I am wondering if
there could be a better solution than tying more the mechanism names
with the expected AUTH_REQ_* values..
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (64+ messages)  latest in thread

Message-ID: <ZBAIe1gnGxknLT7t@paquier.xyz>
Permalink:  ../ZBAIe1gnGxknLT7t@paquier.xyz/
Also on:    postgresql.org/message-id/ZBAIe1gnGxknLT7t@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, jchampion@timescale.com, aleksander@timescale.com, peter.eisentraut@enterprisedb.com, david.g.johnston@gmail.com
  Subject: Re: [PoC] Let libpq reject unexpected authentication requests
  In-Reply-To: <ZBAIe1gnGxknLT7t@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox