From: Justin Pryzby <pryzby@telsasoft.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Alexander Lakhin <exclusion@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Fix typos and inconsistencies for v16
Date: Tue, 18 Apr 2023 13:47:21 -0500
Message-ID: <ZD7luYOGJs8DtDcJ@telsasoft.com> (raw)
In-Reply-To: <CAApHDvpQWpB81E=Vb5zTrJdD_jeZ613ngt4KzQ=TUzOCftaREg@mail.gmail.com>
References: <d5f68d19-c0fc-91a9-118d-7c6a5a3f5fad@gmail.com>
<ZD3D1QxoccnN8A1V@telsasoft.com>
<CAApHDvpQWpB81E=Vb5zTrJdD_jeZ613ngt4KzQ=TUzOCftaREg@mail.gmail.com>
On Tue, Apr 18, 2023 at 02:06:43PM +1200, David Rowley wrote:
> On Tue, 18 Apr 2023 at 10:10, Justin Pryzby <pryzby@telsasoft.com> wrote:
> > > - * USER SET values are appliciable only for PGC_USERSET parameters. We
> > > + * USER SET values are applicable only for PGC_USERSET parameters. We
> > > * use InvalidOid as role in order to evade possible privileges of the
> >
> > and s/evade/avoid/
>
> I didn't touch this. You'll need to provide more justification for why
> you think it's more correct than what's there.
I'd noticed that it's a substitution/mistake that's been made in the
past. I dug up:
9436041ed848debb3d64fb5fbff6cdb35bc46d04
8e12f4a250d250a89153da2eb9b91c31bb80c483
cd9479af2af25d7fa9bfd24dd4dcf976b360f077
6df7a9698bb036610c1e8c6d375e1be38cb26d5f
911e70207703799605f5a0e8aad9f06cff067c63
> It might not be worth too much discussion, however.
+many. I may resend the patch at some later date.
> > Attached some others that I found.
>
> Pushed the rest. Thanks
Thanks!
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, dgrowleyml@gmail.com, exclusion@gmail.com
Subject: Re: Fix typos and inconsistencies for v16
In-Reply-To: <ZD7luYOGJs8DtDcJ@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox