From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: gkokolatos@pm.me, shiy.fnst@fujitsu.com, pgsql-hackers@lists.postgresql.org, Rachel Heaton <rachelmheaton@gmail.com>
Subject: Re: Add LZ4 compression in pg_dump
Date: Tue, 11 Apr 2023 20:19:59 -0500
Message-ID: <ZDYHP4SvY2eejTj/@telsasoft.com> (raw)
In-Reply-To: <ZDYEPDbFAua+4hlr@paquier.xyz>
References: <qRJGr1JjK3B_pbOxyGqI0iGJWEcRxnq9c7_mIqTY1CIIvYMY0hamPIrvjuS-6gyjr_ItOG8SLRacF1oj7d8R4QKHfZp85YTHI9B-U6LSLAQ=@pm.me>
<qSzzmYsXqUf1gDvFspOEbqoE8U_F8IsphDG8c25VZ5KTXimQVYfLvnCcuU7_X2raa2SzZinDF0NpDIKSOALRUYP8pu_NL5QJwIDdR_RT-4U=@pm.me>
<8ffd14fe-0278-7f8d-78d4-472816d06268@enterprisedb.com>
<ZDX+J72FYmJhH+fC@telsasoft.com>
<ZDYEPDbFAua+4hlr@paquier.xyz>
On Wed, Apr 12, 2023 at 10:07:08AM +0900, Michael Paquier wrote:
> On Tue, Apr 11, 2023 at 07:41:11PM -0500, Justin Pryzby wrote:
> > Maybe I would write it as: "if zlib is unavailable, default to no
> > compression". But I think that's best done in the leading comment, and
> > not inside an empty preprocessor #else.
> >
> > I was hoping Michael would comment on this.
>
> (Sorry for the late reply, somewhat missed that.)
>
> > The placement and phrasing of the comment makes no sense to me.
>
> Yes, this comment gives no value as it stands. I would be tempted to
> follow the suggestion to group the whole code block in a single ifdef,
> including the check, and remove this comment. Like the attached
> perhaps?
+1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, michael@paquier.xyz, tomas.vondra@enterprisedb.com, rachelmheaton@gmail.com
Subject: Re: Add LZ4 compression in pg_dump
In-Reply-To: <ZDYHP4SvY2eejTj/@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox