public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Bharath Rupireddy <[email protected]>
Cc: Kyotaro Horiguchi <[email protected]>
Cc: [email protected]
Cc: [email protected]
Subject: Re: pg_recvlogical prints bogus error when interrupted
Date: Thu, 27 Apr 2023 15:22:02 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CALj2ACWgqdUiwEY7o85V9Meb21Qa+Y8qxPprT82-ok8WhXArUw@mail.gmail.com>
References: <[email protected]>
<CALj2ACUAd==wVcQxbkhxAmoegs2g_b+OX8moL68NzjtnFeoM4A@mail.gmail.com>
<[email protected]>
<CALj2ACWrLuSpXT87HA91Y=1_SefBM2uL9BCffm2VPretBCfgWQ@mail.gmail.com>
<[email protected]>
<CALj2ACWgqdUiwEY7o85V9Meb21Qa+Y8qxPprT82-ok8WhXArUw@mail.gmail.com>
On Thu, Apr 27, 2023 at 11:24:52AM +0530, Bharath Rupireddy wrote:
> IMO, +1 for HEAD/PG16 and +0.5 for backpatching as it may not be so
> critical to backpatch all the way down. What may happen without this
> patch is that the output file isn't fsync-ed upon SIGINT/SIGTERM.
> Well, is it a critical issue on production servers?
It is also true that it's been this way for years with basically
nobody complaining outside this thread. So there is also an argument
about leaving v16 out of the picture, and do that only in 17~ to avoid
playing with the branch stability more than necessary? I see 7 open
items as of today, and there are TAP tests linked to pg_recvlogical.
That should be OK, because none of these tests rely on specific
signals, but the buildfarm has some weird setups, as well..
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (4+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: pg_recvlogical prints bogus error when interrupted
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox