pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Drouvot, Bertrand <bertranddrouvot.pg@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Introduce WAIT_EVENT_EXTENSION and WAIT_EVENT_BUFFER_PIN
Date: Fri, 19 May 2023 07:36:32 +0900
Message-ID: <ZGaocGfirEt6OXNP@paquier.xyz> (raw)
In-Reply-To: <CA+TgmoaYTd3YN3N3vtXi+X63ePOzAdiKfVYX-BROtpWSdF-Auw@mail.gmail.com>
References: <c6f35117-4b20-4c78-1df5-d3056010dcf5@gmail.com>
	<20230515182956.5lavflljhpgpokxc@awork3.anarazel.de>
	<ZGKynuIpQp1G8Bec@paquier.xyz>
	<20230516001716.iy7no2q77vwdt5w2@awork3.anarazel.de>
	<ZGLQnikZoxsqj2dl@paquier.xyz>
	<20230516010102.jwmsuaoynz6zfqmn@awork3.anarazel.de>
	<ZGMRMrrz02v8MGTE@paquier.xyz>
	<CA+TgmobtMj42OoAqETwhmiNU3k9LB+MiZhK+qdKg4Jh3Dq-Dag@mail.gmail.com>
	<20230517233832.si5zpq3qnxmx3swb@awork3.anarazel.de>
	<CA+TgmoaYTd3YN3N3vtXi+X63ePOzAdiKfVYX-BROtpWSdF-Auw@mail.gmail.com>

On Thu, May 18, 2023 at 12:28:20PM -0400, Robert Haas wrote:
> I mean, I agree that it would probably be hard to measure any real
> performance difference. But I'm not sure that's a good reason to add
> cycles to a path where we don't really need to.

Honestly, I am not sure that it's worth worrying about performance
here, or perhaps you know of some external stuff that could set the
extension class type in a code path hot enough that it would matter.
Anyway, why couldn't we make all these functions static inline
instead, then?
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (25+ messages)  latest in thread

Message-ID: <ZGaocGfirEt6OXNP@paquier.xyz>
Permalink:  ../ZGaocGfirEt6OXNP@paquier.xyz/
Also on:    postgresql.org/message-id/ZGaocGfirEt6OXNP@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, robertmhaas@gmail.com, andres@anarazel.de, bertranddrouvot.pg@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Introduce WAIT_EVENT_EXTENSION and WAIT_EVENT_BUFFER_PIN
  In-Reply-To: <ZGaocGfirEt6OXNP@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox