public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Japin Li <[email protected]>
Cc: Richard Guo <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Another incorrect comment for pg_stat_statements
Date: Wed, 28 Jun 2023 16:04:48 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <MEYP282MB1669FB3A6F7AD9B0D949CA7CB624A@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
References: <MEYP282MB1669FC91C764E277821936D3B624A@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
<CAMbWs4_ZFNUw59JhAnKUm+SLtaBvJ3FicLQKg0YXJ2mWGH2hGQ@mail.gmail.com>
<MEYP282MB1669FB3A6F7AD9B0D949CA7CB624A@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM>
On Wed, Jun 28, 2023 at 12:15:47PM +0800, Japin Li wrote:
> - /* Remove the key if it exists, starting with the top-level entry */
> + /* Remove the key if it exists, starting with the non-top-level entry */
> key.toplevel = false;
> entry = (pgssEntry *) hash_search(pgss_hash, &key, HASH_REMOVE, NULL);
> if (entry) /* found */
Nice catch. That's indeed wrong. Will fix.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (3+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Another incorrect comment for pg_stat_statements
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox