pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: vignesh C <vignesh21@gmail.com>
Cc: Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Subject: Re: pg_upgrade and logical replication
Date: Wed, 20 Sep 2023 09:38:56 +0900
Message-ID: <ZQo_ICnuwsNcPsgL@paquier.xyz> (raw)
In-Reply-To: <CALDaNm2g9ZKf=y8X6z6MsLCuh8WwU-=Q6pLj35NFi2M5BZNS_A@mail.gmail.com>
References: <20230407022802.jqmdhgjhrnj5lpcl@jrouhaud>
	<TYAPR01MB586682CF17623F6E71B9D3ADF59D9@TYAPR01MB5866.jpnprd01.prod.outlook.com>
	<20230424072224.qd3awkfrjcanw2pa@jrouhaud>
	<TYAPR01MB5866FE3A990CAE1FFA3F1472F56A9@TYAPR01MB5866.jpnprd01.prod.outlook.com>
	<CALDaNm1ZrbHaWpJwwNhDTJocRKWd3rEkgJazuDdZ9Z-WdvonFg@mail.gmail.com>
	<TYAPR01MB5866F1BA00D86EA7EA134348F5F1A@TYAPR01MB5866.jpnprd01.prod.outlook.com>
	<CALDaNm1JzqTreCUrhNu5E1gq7Q8r_u3+FrisyT7moOED=UdoCg@mail.gmail.com>
	<CALDaNm00MF-d=4TToFxXtpzyZWRK_mq1_ih47wkjn5+reWN5PQ@mail.gmail.com>
	<ZQk9cdX2cGoyx5Wl@paquier.xyz>
	<CALDaNm2g9ZKf=y8X6z6MsLCuh8WwU-=Q6pLj35NFi2M5BZNS_A@mail.gmail.com>

On Tue, Sep 19, 2023 at 07:14:49PM +0530, vignesh C wrote:
> Here is a patch to set max_logical_replication_workers as 0 while the
> server is started to prevent the launcher from being started. Since
> this configuration is present from v10, no need for any version check.
> I have done upgrade tests for v10-master, v11-master, ... v16-master
> and found it to be working fine.

The project policy is to support pg_upgrade for 10 years, and 9.6 was
released in 2016:
https://www.postgresql.org/docs/9.6/release-9-6.html

>      snprintf(cmd, sizeof(cmd),
> -             "\"%s/pg_ctl\" -w -l \"%s/%s\" -D \"%s\" -o \"-p %d -b%s %s%s\" start",
> +             "\"%s/pg_ctl\" -w -l \"%s/%s\" -D \"%s\" -o \"-p %d -b%s %s%s%s\" start",
>               cluster->bindir,
>               log_opts.logdir,
>               SERVER_LOG_FILE, cluster->pgconfig, cluster->port,
>               (cluster == &new_cluster) ?
>               " -c synchronous_commit=off -c fsync=off -c full_page_writes=off" : "",
> +             " -c max_logical_replication_workers=0",
>               cluster->pgopts ? cluster->pgopts : "", socket_string);
>  
>      /*

And this code path is used to start postmaster instances for old and
new clusters.  So it seems to me that it is incorrect if this is not
conditional based on the cluster version.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (221+ messages)  latest in thread

Message-ID: <ZQo_ICnuwsNcPsgL@paquier.xyz>
Permalink:  ../ZQo_ICnuwsNcPsgL@paquier.xyz/
Also on:    postgresql.org/message-id/ZQo_ICnuwsNcPsgL@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, vignesh21@gmail.com, kuroda.hayato@fujitsu.com, rjuju123@gmail.com, pgsql-hackers@lists.postgresql.org, amit.kapila16@gmail.com
  Subject: Re: pg_upgrade and logical replication
  In-Reply-To: <ZQo_ICnuwsNcPsgL@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox