public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: '[email protected]' <[email protected]>
Subject: Re: Remove wal_level settings for subscribers in tap tests
Date: Wed, 18 Oct 2023 15:39:16 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <TYAPR01MB5866946BCEB747ABE513ACC6F5D5A@TYAPR01MB5866.jpnprd01.prod.outlook.com>
References: <TYAPR01MB5866946BCEB747ABE513ACC6F5D5A@TYAPR01MB5866.jpnprd01.prod.outlook.com>
On Wed, Oct 18, 2023 at 02:59:52AM +0000, Hayato Kuroda (Fujitsu) wrote:
> While discussing [1], I found that in tap tests, wal_level was set to logical for
> subscribers too. The setting is not needed for subscriber side, and it may cause
> misunderstanding for newcomers. Therefore, I wanted to propose the patch which
> removes unnecessary "allows_streaming => 'logical'".
> I grepped with the string and checked the necessity of them one by one.
>
> How do you think?
>
> [1]: https://commitfest.postgresql.org/45/4273/
Hmm, okay. On top of your argument, this may be a good idea for a
different reason: it makes the tests a bit cheaper as "logical"
generates a bit more WAL. Still the gain is marginal.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (3+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Remove wal_level settings for subscribers in tap tests
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox