public inbox for [email protected]  

help / color / mirror / Atom feed

From: Michael Paquier <[email protected]>
To: Nishant Sharma <[email protected]>
Cc: [email protected]
Subject: Re: [Code Cleanup] : Small code cleanup in twophase.sql
Date: Tue, 10 Oct 2023 15:04:14 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CADrsxdb0ueGV9nrC6s8zvXLkGUhnEjx7Ou_p5wo38TvmSvF83A@mail.gmail.com>
References: <CADrsxdb0ueGV9nrC6s8zvXLkGUhnEjx7Ou_p5wo38TvmSvF83A@mail.gmail.com>

On Tue, Sep 26, 2023 at 06:31:42PM +0530, Nishant Sharma wrote:
> To support it I have below points:-
> 
> 1) Grepping this table 'test_prepared_savepoint' shows occurrences
> only in twophase.out & twophase.sql files. This means that table is
> local to that sql test file and not used in any other test file.
> 
> 2) I don't see any comment on why this was not added in the cleanup
> section of twophase.sql, but drop for other two test tables are done.
> 
> 3) I ran "make check-world" with the patch and I don't see any failures.

Note that sometimes tables are left around in the regression tests for
pg_upgrade, so as we can test dedicated upgrade paths for some object
types.  But, here, I think you're right: this is not a table that
matters for an upgrade and the end of the test file also expects a
cleanup.  So okay for me to drop this table here.
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
  download

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [Code Cleanup] : Small code cleanup in twophase.sql
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox