From: Mark Wong <markwkm@gmail.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Ronan Dunklau <ronan.dunklau@aiven.io>
Cc: Devrim Gündüz <devrim@gunduz.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Subject: Re: LLVM 16 (opaque pointers)
Date: Mon, 23 Oct 2023 16:05:44 -0700
Message-ID: <ZTb8SIkanbUaahLu@moubin> (raw)
In-Reply-To: <CA+hUKGJn5GMUTNBmk4h6e5Tuh380JaQXPudB1wnNAXvrbuPnNA@mail.gmail.com>
References: <CA+hUKG+hopeRBGVwS4JE3uy1UO3TRnhF08HMiSpMrPODgtiw9Q@mail.gmail.com>
<CA+hUKGKReczOCzaL8J2aGv2YBOLDGJaLpF1wVmhtpFp6QmQagg@mail.gmail.com>
<20231020221213.zlgwsh7wtwyz33ag@awork3.anarazel.de>
<CA+hUKGLZKP8yvnutdbofyAs4sjSaBNzQCN8vf-CM3S3da08XcQ@mail.gmail.com>
<CA+hUKG+XE-4ZkY+_Yf-reDcnZz7ZvVfEWFYSEqWTx6HrSWk9_Q@mail.gmail.com>
<4022690.1697852728@sss.pgh.pa.us>
<CA+hUKGKh54+t2Yj_ramkFG9F_2F5GUdxps4jCz18hzBKK-e_LA@mail.gmail.com>
<CA+hUKGLQ38rgZ3bvNHXPRjsWFAg3pa=tnpeq0osa+=miFD5jAw@mail.gmail.com>
<ZTaQ2wD6nTUdo6dG@moubin>
<CA+hUKGJn5GMUTNBmk4h6e5Tuh380JaQXPudB1wnNAXvrbuPnNA@mail.gmail.com>
On Tue, Oct 24, 2023 at 10:17:22AM +1300, Thomas Munro wrote:
> On Tue, Oct 24, 2023 at 4:27 AM Mark Wong <markwkm@gmail.com> wrote:
> > I haven't gotten around to disabling llvm on any of my animals with llvm
> > < 7 yet. Do you still want to hold on that?
>
> Yes, please disable --with-llvm on s390x and POWER animals with LLVM <
> 7 (see below). Also, you have a bunch of machines with LLVM 16 that
> are failing to compile on REL_11_STABLE. That is expected, because we
> agreed not to back-patch the LLVM 16 API changes into REL_11_STABLE:
>
> > kingsnake: 16.0.6 Fedora Linux 38
> > krait: CentOS 16.0.6 Stream 8
> > lancehead: CentOS 16.0.6 Stream 8
I should have updated these to not use --with-llvm for REL_11_STABLE.
> These POWER machines fail as expected, and it's unfixable:
>
> > elasmobranch: 5.0.1 openSUSE Leap 15.0
> > demoiselle: 5.0.1 openSUSE Leap 15.0
> > cavefish: 6.0.0 Ubuntu 18.04.6 LTS
These should now be updated to not use --with-llvm at all.
> These s390x animals are failing, but don't show the layout complaint.
> I can see that LLVM 6 also lacked a case for s390x in
> llvm::orc::createLocalIndirectStubsManagerBuilder(), the thing that
> was fixed in 7 with the addition of a default case. Therefore these
> presumably fail just like old LLVM on POWER, and it's unfixable. So I
> suggest turning off --with-llvm on these two:
>
> > cotinga: 6.0.0 Ubuntu 18.04.6 LTS
> > perch: 6.0.0 Ubuntu 18.04.6 LTS
Ok, I should have removed --with-llvm here too.
> This s390x animal doesn't actually have --with-llvm enabled so it
> passes, but surely it'd be just like lora:
>
> > mamushi: 15.0.7 Red Hat Enterprise Linux 9.2
Oops, I think I added it now.
I think I made all the recommended changes, and trimmed out the lines
where I didn't need to do anything. :)
Andres pointed out to me that my animals aren't set up to collect core
file so I'm also trying to update that too...
Regards,
Mark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: markwkm@gmail.com, thomas.munro@gmail.com, tgl@sss.pgh.pa.us, ronan.dunklau@aiven.io, devrim@gunduz.org, pgsql-hackers@lists.postgresql.org, coelho@cri.ensmp.fr, 9erthalion6@gmail.com, andres@anarazel.de
Subject: Re: LLVM 16 (opaque pointers)
In-Reply-To: <ZTb8SIkanbUaahLu@moubin>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox