public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Aleksander Alekseev <[email protected]>
Cc: Postgres hackers <[email protected]>
Subject: Re: Typo with amtype = 's' in opr_sanity.sql
Date: Wed, 22 Nov 2023 09:34:24 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAJ7c6TOsBVSn46_M6QnWOZtPSPvZMGi-+M8sSaDdtqyWZNCtBw@mail.gmail.com>
References: <[email protected]>
<CAJ7c6TOsBVSn46_M6QnWOZtPSPvZMGi-+M8sSaDdtqyWZNCtBw@mail.gmail.com>
On Tue, Nov 21, 2023 at 01:02:40PM +0300, Aleksander Alekseev wrote:
>> It seems to me that this has been copy-pasted on HEAD from the
>> sequence AM patch, but forgot to update amtype to 't'. While that's
>> maybe cosmetic, I think that this could lead to unexpected results, so
>> perhaps there is a point in doing a backpatch?
>
> I disagree that it's cosmetic. The test doesn't check what it's supposed to.
Yes, I've backpatched that all the way down to 12 at the end.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (4+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Typo with amtype = 's' in opr_sanity.sql
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox