public inbox for [email protected]  

help / color / mirror / Atom feed

From: Michael Paquier <[email protected]>
To: Tom Lane <[email protected]>
Cc: Laurenz Albe <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Daniel Gustafsson <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: GUC names in messages
Date: Tue, 28 Nov 2023 07:53:37 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<CAHut+Pu91ik+U1ffV4e9a7R_aHFdqNrF8mBJ4FYtPfo8oDL6Yw@mail.gmail.com>
	<[email protected]>
	<CAHut+Pvy=7Sk8Jz9YzU+0Brp1Ki=0DNz6eRgosDCfAAaT+vWHQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>

On Mon, Nov 27, 2023 at 01:35:44AM -0500, Tom Lane wrote:
> Laurenz Albe <[email protected]> writes:
> > On Mon, 2023-11-27 at 13:41 +1100, Peter Smith wrote:
>>> In the documentation and in the guc_tables.c they are all described in
>>> MixedCase (e.g. "DateStyle" instead of "datestyle"), so I felt the
>>> messages should use the same case the documentation, which is why I
>>> changed all the ones you are referring to.
> 
>> I agree with that decision; we should use mixed case for these parameters.
>> Otherwise we might get complaints that the following query does not return
>> any results:
>>   SELECT * FROM pg_settings WHERE name = 'timezone';

(I'm sure that you mean the opposite.  This query does not return any
results on HEAD, but it would with "TimeZone".)

> Yeah.  Like Michael upthread, I've wondered occasionally about changing
> these names to all-lower-case.  It'd surely be nicer if we'd done it
> like that to begin with.  But I can't convince myself that the ensuing
> user pain would be justified.

Perhaps not.  I'd like to think that a lot of queries on pg_settings
have the wisdom to apply a lower() or upper(), but that's very
unlikely.

-    errhint("Perhaps you need a different \"datestyle\" setting.")));
+    errhint("Perhaps you need a different DateStyle setting.")));

Saying that, I'd let this one be in 0002.  It causes a log of diff
churn in the tests and quoting it based on Alvaro's suggestion would
still be correct because it's fully lower-case.  (Yeah, I'm perhaps
nit-ing here, so feel free to counter-argue if you prefer what the
patch does.)
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
  download

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: GUC names in messages
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox